suzanne.soy/FreeCAD
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

performance improvements

Browse Source 
+ use const-reference as argument to avoid tmp. copy
+ use prefix incremation operator instead of postfix increment operator
This commit is contained in:
wmayer 2016-11-08 13:51:22 +01:00
parent 85170b3d9f
commit 17c8b2c813
6 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Mod/Measure/App/Measurement.cpp
View File

@ -86,7 +86,7 @@ bool Measurement::has3DReferences()
}
//add a 3D reference (obj+sub) to end of list
int Measurement::addReference3D(App::DocumentObject *obj, const std::string subName)
int Measurement::addReference3D(App::DocumentObject *obj, const std::string& subName)
{
return addReference3D(obj,subName.c_str());
}

2
src/Mod/Measure/App/Measurement.h
View File

@ -58,7 +58,7 @@ public:
bool has3DReferences();
/// Add a reference
int addReference3D(App::DocumentObject* obj, const std::string subName);
int addReference3D(App::DocumentObject* obj, const std::string& subName);
int addReference3D(App::DocumentObject* obj, const char *subName);
MeasureType getType();

6
src/Mod/TechDraw/App/DrawProjectSplit.cpp
View File

@ -167,7 +167,7 @@ std::vector<TopoDS_Edge> DrawProjectSplit::getEdges(TechDrawGeometry::GeometryOb
std::vector<splitPoint> splits;
std::vector<TopoDS_Edge>::iterator itOuter = origEdges.begin();
int iOuter = 0;
for (; itOuter != origEdges.end(); itOuter++, iOuter++) {
for (; itOuter != origEdges.end(); ++itOuter, iOuter++) {
TopoDS_Vertex v1 = TopExp::FirstVertex((*itOuter));
TopoDS_Vertex v2 = TopExp::LastVertex((*itOuter));
Bnd_Box sOuter;
@ -183,7 +183,7 @@ std::vector<TopoDS_Edge> DrawProjectSplit::getEdges(TechDrawGeometry::GeometryOb
}
int iInner = 0;
std::vector<TopoDS_Edge>::iterator itInner = faceEdges.begin();
for (; itInner != faceEdges.end(); itInner++,iInner++) {
for (; itInner != faceEdges.end(); ++itInner,iInner++) {
if (iInner == iOuter) {
continue;
}
@ -373,7 +373,7 @@ std::vector<TopoDS_Edge> DrawProjectSplit::split1Edge(TopoDS_Edge e, std::vector
auto parms2 = parms.begin() + 1;
std::vector<double>::iterator psecond = parms2;
std::vector<double>::iterator pstop = parms.end();
for (; psecond != pstop; pfirst++,psecond++) {
for (; psecond != pstop; ++pfirst,++psecond) {
try {
BRepBuilderAPI_MakeEdge mkEdge(c, *pfirst, *psecond);
if (mkEdge.IsDone()) {

4
src/Mod/TechDraw/App/DrawViewPart.cpp
View File

@ -292,7 +292,7 @@ void DrawViewPart::extractFaces()
std::vector<splitPoint> splits;
std::vector<TopoDS_Edge>::iterator itOuter = origEdges.begin();
int iOuter = 0;
for (; itOuter != origEdges.end(); itOuter++, iOuter++) {
for (; itOuter != origEdges.end(); ++itOuter, iOuter++) {
TopoDS_Vertex v1 = TopExp::FirstVertex((*itOuter));
TopoDS_Vertex v2 = TopExp::LastVertex((*itOuter));
Bnd_Box sOuter;
@ -308,7 +308,7 @@ void DrawViewPart::extractFaces()
}
int iInner = 0;
std::vector<TopoDS_Edge>::iterator itInner = faceEdges.begin();
for (; itInner != faceEdges.end(); itInner++,iInner++) {
for (; itInner != faceEdges.end(); ++itInner,iInner++) {
if (iInner == iOuter) {
continue;
}

2
src/Mod/TechDraw/App/GeometryObject.cpp
View File

@ -76,7 +76,7 @@ struct EdgePoints {
TopoDS_Edge edge;
};
GeometryObject::GeometryObject(std::string parent) :
GeometryObject::GeometryObject(const string& parent) :
Scale(1.f),
m_parentName(parent),
m_isoCount(0)

2
src/Mod/TechDraw/App/GeometryObject.h
View File

@ -61,7 +61,7 @@ class TechDrawExport GeometryObject
{
public:
/// Constructor
GeometryObject(std::string parent);
GeometryObject(const std::string& parent);
virtual ~GeometryObject();
void clear();