suzanne.soy/FreeCAD
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

+ fix issue with bad default value of natural direction

Browse Source
This commit is contained in:
wmayer 2015-02-20 14:40:03 +01:00
parent a869033925
commit 18f1cf7821
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/Mod/Fem/App/FemConstraintForce.cpp
View File

@ -52,7 +52,7 @@ ConstraintForce::ConstraintForce()
"Points where arrows are drawn"); "Points where arrows are drawn");
ADD_PROPERTY_TYPE(DirectionVector,(Base::Vector3d(0,0,1)),"ConstraintForce",App::PropertyType(App::Prop_ReadOnly|App::Prop_Output), ADD_PROPERTY_TYPE(DirectionVector,(Base::Vector3d(0,0,1)),"ConstraintForce",App::PropertyType(App::Prop_ReadOnly|App::Prop_Output),
"Direction of arrows"); "Direction of arrows");
naturalDirectionVector = Base::Vector3d(0,0,1); naturalDirectionVector = Base::Vector3d(0,0,0); // by default use the null vector to indication an invalid value
Points.setValues(std::vector<Base::Vector3d>()); Points.setValues(std::vector<Base::Vector3d>());
} }
@ -72,7 +72,6 @@ void ConstraintForce::onChanged(const App::Property* prop)
std::vector<Base::Vector3d> normals; std::vector<Base::Vector3d> normals;
if (getPoints(points, normals)) { if (getPoints(points, normals)) {
Points.setValues(points); // We don't use the normals because all arrows should have the same direction Points.setValues(points); // We don't use the normals because all arrows should have the same direction
Points.touch(); // This triggers ViewProvider::updateData()
} }
} else if (prop == &Direction) { } else if (prop == &Direction) {
Base::Vector3d direction = getDirection(Direction); Base::Vector3d direction = getDirection(Direction);
@ -82,14 +81,13 @@ void ConstraintForce::onChanged(const App::Property* prop)
if (Reversed.getValue()) if (Reversed.getValue())
direction = -direction; direction = -direction;
DirectionVector.setValue(direction); DirectionVector.setValue(direction);
DirectionVector.touch();
} else if (prop == &Reversed) { } else if (prop == &Reversed) {
if (Reversed.getValue() && (DirectionVector.getValue() == naturalDirectionVector)) { if (naturalDirectionVector.Length() >= Precision::Confusion()) {
DirectionVector.setValue(-naturalDirectionVector); if (Reversed.getValue() && (DirectionVector.getValue() == naturalDirectionVector)) {
DirectionVector.touch(); DirectionVector.setValue(-naturalDirectionVector);
} else if (!Reversed.getValue() && (DirectionVector.getValue() != naturalDirectionVector)) { } else if (!Reversed.getValue() && (DirectionVector.getValue() != naturalDirectionVector)) {
DirectionVector.setValue(naturalDirectionVector); DirectionVector.setValue(naturalDirectionVector);
DirectionVector.touch(); }
} }
} else if (prop == &NormalDirection) { } else if (prop == &NormalDirection) {
// Set a default direction if no direction reference has been given // Set a default direction if no direction reference has been given