Coverity issues:

129727: Structurally dead code
151979, 133461: Uninitialized scalar field
129785, 129786, 129787: Use after free
This commit is contained in:
wmayer 2016-08-16 12:23:12 +02:00
parent 18555102a1
commit 1c8045756f
4 changed files with 5 additions and 3 deletions

View File

@ -1012,9 +1012,9 @@ void unexpection_error_handler()
// try to throw an exception and give the user chance to save their work // try to throw an exception and give the user chance to save their work
#if !defined(_DEBUG) #if !defined(_DEBUG)
throw Base::Exception("Unexpected error occurred! Please save your work under a new file name and restart the application!"); throw Base::Exception("Unexpected error occurred! Please save your work under a new file name and restart the application!");
#endif #else
terminate(); terminate();
#endif
} }
#ifdef _MSC_VER // Microsoft compiler #ifdef _MSC_VER // Microsoft compiler

View File

@ -56,6 +56,7 @@ ColorModel& ColorModel::operator = (const ColorModel &rclM)
return *this; return *this;
delete [] _pclColors; delete [] _pclColors;
_pclColors = 0;
_usColors = rclM._usColors; _usColors = rclM._usColors;
if (_usColors == 0) if (_usColors == 0)

View File

@ -773,7 +773,7 @@ private:
class StdDevCollector : public Collector { class StdDevCollector : public Collector {
public: public:
StdDevCollector() : Collector() { } StdDevCollector() : Collector(), n(0) { }
void collect(Quantity value) { void collect(Quantity value) {
Collector::collect(value); Collector::collect(value);

View File

@ -470,6 +470,7 @@ ObjectIdentifier::Component::Component(const String &_component, ObjectIdentifie
, type(_type) , type(_type)
, index(_index) , index(_index)
, key(_key) , key(_key)
, keyIsString(false)
{ {
} }