diff --git a/src/Mod/Part/App/PrimitiveFeature.cpp b/src/Mod/Part/App/PrimitiveFeature.cpp index 34818bc95..a2dcf68b3 100644 --- a/src/Mod/Part/App/PrimitiveFeature.cpp +++ b/src/Mod/Part/App/PrimitiveFeature.cpp @@ -471,8 +471,8 @@ PROPERTY_SOURCE(Part::Prism, Part::Primitive) Prism::Prism(void) { - ADD_PROPERTY_TYPE(Polygon,(6.0),"Prism",App::Prop_None,"The polygon of the prism"); - ADD_PROPERTY_TYPE(Length,(2.0),"Prism",App::Prop_None,"The edge length of the prism"); + ADD_PROPERTY_TYPE(Polygon,(6.0),"Prism",App::Prop_None,"Number of sides in the polygon, of the prism"); + ADD_PROPERTY_TYPE(Circumradius,(2.0),"Prism",App::Prop_None,"Circumradius (centre to vertex) of the polygon, of the prism"); ADD_PROPERTY_TYPE(Height,(10.0f),"Prism",App::Prop_None,"The height of the prism"); Polygon.setConstraints(&polygonRange); } @@ -481,7 +481,7 @@ short Prism::mustExecute() const { if (Polygon.isTouched()) return 1; - if (Length.isTouched()) + if (Circumradius.isTouched()) return 1; if (Height.isTouched()) return 1; @@ -492,11 +492,11 @@ App::DocumentObjectExecReturn *Prism::execute(void) { // Build a prism if (Polygon.getValue() < 3) - return new App::DocumentObjectExecReturn("Polygon of prism is invalid"); - if (Length.getValue() < Precision::Confusion()) - return new App::DocumentObjectExecReturn("Radius of prism too small"); + return new App::DocumentObjectExecReturn("Polygon of prism is invalid, must have 3 or more sides"); + if (Circumradius.getValue() < Precision::Confusion()) + return new App::DocumentObjectExecReturn("Circumradius of the polygon, of the prism, is too small"); if (Height.getValue() < Precision::Confusion()) - return new App::DocumentObjectExecReturn("Height of prism too small"); + return new App::DocumentObjectExecReturn("Height of prism is too small"); try { long nodes = Polygon.getValue(); @@ -505,7 +505,7 @@ App::DocumentObjectExecReturn *Prism::execute(void) // create polygon BRepBuilderAPI_MakePolygon mkPoly; - Base::Vector3d v(Length.getValue(),0,0); + Base::Vector3d v(Circumradius.getValue(),0,0); for (long i=0; ivalue()) - .arg(ui.prismLength->value(),0,'f',2) + .arg(ui.prismCircumradius->value(),0,'f',2) .arg(ui.prismHeight->value(),0,'f',2) .arg(placement); } @@ -598,12 +598,12 @@ void DlgPrimitives::createPrimitive(const QString& placement) name = QString::fromAscii(doc->getUniqueObjectName("RegularPolygon").c_str()); cmd = QString::fromAscii( "App.ActiveDocument.addObject(\"Part::RegularPolygon\",\"%1\")\n" - "App.ActiveDocument.%1.NumberOfSides=%2\n" - "App.ActiveDocument.%1.Radius=%3\n" + "App.ActiveDocument.%1.Polygon=%2\n" + "App.ActiveDocument.%1.Circumradius=%3\n" "App.ActiveDocument.%1.Placement=%4\n") .arg(name) - .arg(ui.regularPolygonNumberOfSides->value()) - .arg(ui.regularPolygonRadius->value(),0,'f',2) + .arg(ui.regularPolygonPolygon->value()) + .arg(ui.regularPolygonCircumradius->value(),0,'f',2) .arg(placement); } diff --git a/src/Mod/Part/Gui/DlgPrimitives.ui b/src/Mod/Part/Gui/DlgPrimitives.ui index 42b8bf97a..c6c1e80d9 100644 --- a/src/Mod/Part/Gui/DlgPrimitives.ui +++ b/src/Mod/Part/Gui/DlgPrimitives.ui @@ -1003,14 +1003,14 @@ - + - Length: + Circumradius: - + 0.000000000000000 @@ -1875,14 +1875,14 @@ 6 - + - Number Of Sides: + Polygon: - + 1000 @@ -1895,14 +1895,14 @@ - + - Radius: + Circumradius: - + 0.000000000000000 diff --git a/src/Mod/Part/Gui/ViewProviderRegularPolygon.cpp b/src/Mod/Part/Gui/ViewProviderRegularPolygon.cpp index 1fff370a7..bcc978196 100644 --- a/src/Mod/Part/Gui/ViewProviderRegularPolygon.cpp +++ b/src/Mod/Part/Gui/ViewProviderRegularPolygon.cpp @@ -59,8 +59,6 @@ std::vector ViewProviderRegularPolygon::getDisplayModes(void) const std::vector StrList; // add your own modes - // StrList.push_back("Flat Lines"); -// StrList.push_back("Shaded"); StrList.push_back("Wireframe"); StrList.push_back("Points");