From 6a2a72627635d9b72d24fa90312586e7967e6f8c Mon Sep 17 00:00:00 2001
From: wmayer <wmayer@users.sourceforge.net>
Date: Sat, 9 Jun 2012 16:37:06 +0200
Subject: [PATCH] Fix bugs in Groove and Revolution

---
 src/Mod/PartDesign/App/FeatureGroove.cpp     | 13 +++++++------
 src/Mod/PartDesign/App/FeatureRevolution.cpp | 15 ++++++++-------
 2 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/src/Mod/PartDesign/App/FeatureGroove.cpp b/src/Mod/PartDesign/App/FeatureGroove.cpp
index 1e7f7d660..1cf17541d 100644
--- a/src/Mod/PartDesign/App/FeatureGroove.cpp
+++ b/src/Mod/PartDesign/App/FeatureGroove.cpp
@@ -52,12 +52,12 @@ PROPERTY_SOURCE(PartDesign::Groove, PartDesign::SketchBased)
 
 Groove::Groove()
 {
-    ADD_PROPERTY(Base,(Base::Vector3f(0.0f,0.0f,0.0f)));
-    ADD_PROPERTY(Axis,(Base::Vector3f(0.0f,1.0f,0.0f)));
-    ADD_PROPERTY(Angle,(360.0));
+    ADD_PROPERTY_TYPE(Base,(Base::Vector3f(0.0f,0.0f,0.0f)),"Groove", App::Prop_ReadOnly, "Base");
+    ADD_PROPERTY_TYPE(Axis,(Base::Vector3f(0.0f,1.0f,0.0f)),"Groove", App::Prop_ReadOnly, "Axis");
+    ADD_PROPERTY_TYPE(Angle,(360.0),"Groove", App::Prop_None, "Angle");
     ADD_PROPERTY_TYPE(ReferenceAxis,(0),"Groove",(App::PropertyType)(App::Prop_None),"Reference axis of Groove");
-    ADD_PROPERTY(Midplane,(0));
-    ADD_PROPERTY(Reversed, (0));
+    ADD_PROPERTY_TYPE(Midplane,(0),"Groove", App::Prop_None, "Mid plane");
+    ADD_PROPERTY_TYPE(Reversed, (0),"Groove", App::Prop_None, "Reversed");
 }
 
 short Groove::mustExecute() const
@@ -68,7 +68,8 @@ short Groove::mustExecute() const
         Axis.isTouched() ||
         Base.isTouched() ||
         Angle.isTouched() ||
-        Midplane.isTouched())
+        Midplane.isTouched() ||
+        Reversed.isTouched())
         return 1;
     return 0;
 }
diff --git a/src/Mod/PartDesign/App/FeatureRevolution.cpp b/src/Mod/PartDesign/App/FeatureRevolution.cpp
index 1a14783ae..a31bebf43 100644
--- a/src/Mod/PartDesign/App/FeatureRevolution.cpp
+++ b/src/Mod/PartDesign/App/FeatureRevolution.cpp
@@ -52,12 +52,12 @@ PROPERTY_SOURCE(PartDesign::Revolution, PartDesign::SketchBased)
 
 Revolution::Revolution()
 {
-    ADD_PROPERTY(Base,(Base::Vector3f(0.0f,0.0f,0.0f)));
-    ADD_PROPERTY(Axis,(Base::Vector3f(0.0f,1.0f,0.0f)));
-    ADD_PROPERTY(Angle,(360.0));
-    ADD_PROPERTY_TYPE(ReferenceAxis,(0),"Revolution",(App::PropertyType)(App::Prop_None),"Reference axis of revolution");
-    ADD_PROPERTY(Midplane,(0));
-    ADD_PROPERTY(Reversed, (0));
+    ADD_PROPERTY_TYPE(Base,(Base::Vector3f(0.0f,0.0f,0.0f)),"Revolution", App::Prop_ReadOnly, "Base");
+    ADD_PROPERTY_TYPE(Axis,(Base::Vector3f(0.0f,1.0f,0.0f)),"Revolution", App::Prop_ReadOnly, "Axis");
+    ADD_PROPERTY_TYPE(Angle,(360.0),"Revolution", App::Prop_None, "Angle");
+    ADD_PROPERTY_TYPE(ReferenceAxis,(0),"Revolution",(App::Prop_None),"Reference axis of revolution");
+    ADD_PROPERTY_TYPE(Midplane,(0),"Revolution", App::Prop_None, "Mid plane");
+    ADD_PROPERTY_TYPE(Reversed, (0),"Revolution", App::Prop_None, "Reversed");
 }
 
 short Revolution::mustExecute() const
@@ -68,7 +68,8 @@ short Revolution::mustExecute() const
         Axis.isTouched() ||
         Base.isTouched() ||
         Angle.isTouched() ||
-        Midplane.isTouched())
+        Midplane.isTouched() ||
+        Reversed.isTouched())
         return 1;
     return 0;
 }