From 73aea7140dafda191450ab14c4777ad5debb0043 Mon Sep 17 00:00:00 2001 From: WandererFan Date: Fri, 28 Oct 2016 19:33:45 -0400 Subject: [PATCH] Fix test script to match new code Fix nullptr bug revealed by bad test script! --- src/Mod/TechDraw/App/DrawViewSection.cpp | 4 +++- src/Mod/TechDraw/TestTechDrawApp.py | 8 ++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/Mod/TechDraw/App/DrawViewSection.cpp b/src/Mod/TechDraw/App/DrawViewSection.cpp index 1fff54d41..29b94c2bd 100644 --- a/src/Mod/TechDraw/App/DrawViewSection.cpp +++ b/src/Mod/TechDraw/App/DrawViewSection.cpp @@ -150,7 +150,9 @@ void DrawViewSection::onChanged(const App::Property* prop) } if (prop == &SectionOrigin) { App::DocumentObject* base = BaseView.getValue(); - base->touch(); + if (base != nullptr) { + base->touch(); + } } } DrawView::onChanged(prop); diff --git a/src/Mod/TechDraw/TestTechDrawApp.py b/src/Mod/TechDraw/TestTechDrawApp.py index bcdce2730..0a58bd3b1 100644 --- a/src/Mod/TechDraw/TestTechDrawApp.py +++ b/src/Mod/TechDraw/TestTechDrawApp.py @@ -47,9 +47,13 @@ class TechDrawTestCases(unittest.TestCase): self.Anno = self.Doc.addObject('TechDraw::DrawViewAnnotation','TestAnno') rc = self.Page.addView(self.Anno) self.Sect = self.Doc.addObject('TechDraw::DrawViewSection','Section') - rc = self.Page.addView(self.Sect) - self.Sect.SectionOrigin = (1.0,1.0,1.0) self.Sect.Source = self.Box + self.Sect.Direction = FreeCAD.Vector(-1.0,0.0,0.0) + self.Sect.BaseView = self.View + self.Sect.SectionDirection = "Right" + self.Sect.SectionOrigin = FreeCAD.Vector(1.0,1.0,1.0) + self.Sect.SectionNormal = FreeCAD.Vector(-1.0,0.0,0.0) + rc = self.Page.addView(self.Sect) self.Doc.recompute() self.failUnless(len(self.Page.Views) == 3)