suzanne.soy/FreeCAD
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HLR looses Shape for some ProjGroupItems

Browse Source
This commit is contained in:
WandererFan 2016-03-06 19:54:50 -05:00 committed by wmayer
parent 012693a190
commit 8a9c708659
2 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Mod/TechDraw/App/DrawProjGroup.cpp
View File

@ -206,10 +206,7 @@ void DrawProjGroup::onChanged(const App::Property* prop)
if ( prop == &ProjectionType ||
prop == &ScaleType ||
prop == &viewOrientationMatrix ||
((prop == &Scale) &&
//!Scale.StatusBits.test(5)) ) {
!(Scale.testStatus(App::Property::ReadOnly) && //TODO: do we really care about property status here?
Scale.testStatus(App::Property::Hidden))) ) {
prop == &Scale ) {
if (!isRestoring()) {
execute();
}

8
src/Mod/TechDraw/App/GeometryObject.cpp
View File

@ -176,9 +176,9 @@ void GeometryObject::initHLR(const TopoDS_Shape &input,
//TODO: hate losing references on recompute! if Shape has changed, aren't reference potentially invalid anyway?
clear();
if (brep_hlr) {
brep_hlr->Remove(1); //remove the old shape from brep (use NbShapes() first? would we ever have > 1 shape?)
//delete brep_hlr; //release old hlralgo
//brep_hlr = NULL;
if (brep_hlr->NbShapes()) { //TODO: hack. in ProjGroupItems sometimes brep_hlr has no shapes when we get here. why??
brep_hlr->Remove(1); //remove the old shape from brep (would we ever have > 1 shape?)
}
}
///TODO: Consider whether it would be possible/beneficial to cache some of this effort (eg don't do scale in OpenCASCADE land) IR
@ -204,7 +204,7 @@ void GeometryObject::initHLR(const TopoDS_Shape &input,
BRepBuilderAPI_Transform mkTrf(input, tempTransform);
transShape = mkTrf.Shape();
brep_hlr = new HLRBRep_Algo(); //leak? when does this get freed?
brep_hlr = new HLRBRep_Algo(); //leak? when does this get freed? handle/smart pointer
brep_hlr->Add(transShape);
// Project the shape into view space with the object's centroid