suzanne.soy/FreeCAD
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

+ fix bug in revolve feature

Browse Source 
git-svn-id: https://free-cad.svn.sourceforge.net/svnroot/free-cad/trunk@5070 e8eeb9e2-ec13-0410-a4a9-efa5cf37419d
This commit is contained in:
wmayer 2011-10-26 11:53:44 +00:00
parent 8285c1d4e5
commit a2cd64d17e
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Mod/PartDesign/App/FeatureRevolution.cpp
View File

@ -36,6 +36,7 @@
#endif #endif
#include <Base/Placement.h> #include <Base/Placement.h>
#include <Base/Tools.h>
#include <Mod/Part/App/Part2DObject.h> #include <Mod/Part/App/Part2DObject.h>
#include "FeatureRevolution.h" #include "FeatureRevolution.h"
@ -111,14 +112,14 @@ App::DocumentObjectExecReturn *Revolution::execute(void)
SketchOrientation.multVec(SketchOrientationVector,SketchOrientationVector); SketchOrientation.multVec(SketchOrientationVector,SketchOrientationVector);
Base::Vector3f b(0,0,0); Base::Vector3f b = Base.getValue();
gp_Pnt pnt(b.x,b.y,b.z); gp_Pnt pnt(b.x,b.y,b.z);
gp_Dir dir(SketchOrientationVector.x,SketchOrientationVector.y,SketchOrientationVector.z); gp_Dir dir(SketchOrientationVector.x,SketchOrientationVector.y,SketchOrientationVector.z);
// get the support of the Sketch if any // get the support of the Sketch if any
App::DocumentObject* SupportLink = static_cast<Part::Part2DObject*>(link)->Support.getValue(); App::DocumentObject* SupportLink = static_cast<Part::Part2DObject*>(link)->Support.getValue();
Part::Feature *SupportObject = 0; Part::Feature *SupportObject = 0;
if(SupportLink && SupportLink->getTypeId().isDerivedFrom(Part::Feature::getClassTypeId())) if (SupportLink && SupportLink->getTypeId().isDerivedFrom(Part::Feature::getClassTypeId()))
SupportObject = static_cast<Part::Feature*>(SupportLink); SupportObject = static_cast<Part::Feature*>(SupportLink);
TopoDS_Shape aFace = makeFace(wires); TopoDS_Shape aFace = makeFace(wires);
@ -126,7 +127,7 @@ App::DocumentObjectExecReturn *Revolution::execute(void)
return new App::DocumentObjectExecReturn("Creating a face from sketch failed"); return new App::DocumentObjectExecReturn("Creating a face from sketch failed");
// revolve the face to a solid // revolve the face to a solid
BRepPrimAPI_MakeRevol RevolMaker(aFace,gp_Ax1(pnt, dir),Angle.getValue()/180.0f*Standard_PI); BRepPrimAPI_MakeRevol RevolMaker(aFace,gp_Ax1(pnt, dir), Base::toRadians<double>(Angle.getValue()));
if (RevolMaker.IsDone()) { if (RevolMaker.IsDone()) {
TopoDS_Shape result = RevolMaker.Shape(); TopoDS_Shape result = RevolMaker.Shape();
@ -146,7 +147,7 @@ App::DocumentObjectExecReturn *Revolution::execute(void)
this->Shape.setValue(result); this->Shape.setValue(result);
} }
else else
return new App::DocumentObjectExecReturn("Could not extrude the sketch!"); return new App::DocumentObjectExecReturn("Could not revolve the sketch!");
return App::DocumentObject::StdReturn; return App::DocumentObject::StdReturn;
} }