suzanne.soy/FreeCAD
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed bug where sketch support face was used for distance measuring instead of sketch face itself (doesn't resolve problem of false positives, though)

Browse Source
This commit is contained in:
jrheinlaender 2012-11-05 20:36:59 +04:30 committed by wmayer
parent b796b3af78
commit ac2f2dc20e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Mod/PartDesign/App/FeatureSketchBased.cpp
View File

@ -452,7 +452,7 @@ void SketchBased::getUpToFace(TopoDS_Face& upToFace,
}
// Check that the upToFace does not intersect the sketch face and
// is not parallel to the extrusion direction
// is not parallel to the extrusion direction (for simplicity, supportface is used instead of sketchshape)
BRepAdaptor_Surface adapt1(TopoDS::Face(supportface));
BRepAdaptor_Surface adapt2(TopoDS::Face(upToFace));
@ -461,7 +461,9 @@ void SketchBased::getUpToFace(TopoDS_Face& upToFace,
throw Base::Exception("SketchBased: Up to face: Must not be parallel to extrusion direction!");
}
BRepExtrema_DistShapeShape distSS(supportface, upToFace);
// We must measure from sketchshape, not supportface, here
// TODO: distSS() sometimes gives false positives for unlimited upToFaces!
BRepExtrema_DistShapeShape distSS(sketchshape, upToFace);
if (distSS.Value() < Precision::Confusion())
throw Base::Exception("SketchBased: Up to face: Must not intersect sketch!");