suzanne.soy/FreeCAD
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

0000910: Circles Extrude Only Surfaces

Browse Source
This commit is contained in:
wmayer 2012-12-18 14:33:59 +01:00
parent 8b006b27dd
commit f176811a4a
1 changed files with 26 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/Mod/Part/App/FeatureExtrusion.cpp
View File

@ -26,7 +26,9 @@
# include <cmath> # include <cmath>
# include <gp_Trsf.hxx> # include <gp_Trsf.hxx>
# include <BRepOffsetAPI_MakeOffset.hxx> # include <BRepOffsetAPI_MakeOffset.hxx>
# include <BRepBuilderAPI_Copy.hxx>
# include <BRepBuilderAPI_MakeFace.hxx> # include <BRepBuilderAPI_MakeFace.hxx>
# include <BRepBuilderAPI_MakeWire.hxx>
# include <BRepBuilderAPI_Transform.hxx> # include <BRepBuilderAPI_Transform.hxx>
# include <BRepOffsetAPI_ThruSections.hxx> # include <BRepOffsetAPI_ThruSections.hxx>
# include <BRepPrimAPI_MakePrism.hxx> # include <BRepPrimAPI_MakePrism.hxx>
@ -86,9 +88,13 @@ App::DocumentObjectExecReturn *Extrusion::execute(void)
Base::SignalException se; Base::SignalException se;
#endif #endif
double distance = std::tan(Base::toRadians(taperAngle)) * vec.Magnitude(); double distance = std::tan(Base::toRadians(taperAngle)) * vec.Magnitude();
const TopoDS_Shape& shape = base->Shape.getValue(); TopoDS_Shape myShape = base->Shape.getValue();
bool isWire = (shape.ShapeType() == TopAbs_WIRE); if (myShape.IsNull())
bool isFace = (shape.ShapeType() == TopAbs_FACE); Standard_Failure::Raise("Cannot extrude empty shape");
// #0000910: Circles Extrude Only Surfaces, thus use BRepBuilderAPI_Copy
myShape = BRepBuilderAPI_Copy(myShape).Shape();
bool isWire = (myShape.ShapeType() == TopAbs_WIRE);
bool isFace = (myShape.ShapeType() == TopAbs_FACE);
if (!isWire && !isFace) if (!isWire && !isFace)
return new App::DocumentObjectExecReturn("Only a wire or a face is supported"); return new App::DocumentObjectExecReturn("Only a wire or a face is supported");
@ -102,7 +108,7 @@ App::DocumentObjectExecReturn *Extrusion::execute(void)
// http://www.opencascade.org/org/forum/thread_17640/ // http://www.opencascade.org/org/forum/thread_17640/
// http://www.opencascade.org/org/forum/thread_12012/ // http://www.opencascade.org/org/forum/thread_12012/
ShapeFix_Wire aFix; ShapeFix_Wire aFix;
aFix.Load(TopoDS::Wire(shape)); aFix.Load(TopoDS::Wire(myShape));
aFix.FixReorder(); aFix.FixReorder();
aFix.FixConnected(); aFix.FixConnected();
aFix.FixClosed(); aFix.FixClosed();
@ -113,7 +119,7 @@ App::DocumentObjectExecReturn *Extrusion::execute(void)
#endif #endif
} }
else if (isFace) { else if (isFace) {
TopoDS_Wire outerWire = ShapeAnalysis::OuterWire(TopoDS::Face(shape)); TopoDS_Wire outerWire = ShapeAnalysis::OuterWire(TopoDS::Face(myShape));
wire_list.push_back(outerWire); wire_list.push_back(outerWire);
mkOffset.AddWire(outerWire); mkOffset.AddWire(outerWire);
} }
@ -123,7 +129,19 @@ App::DocumentObjectExecReturn *Extrusion::execute(void)
gp_Trsf mat; gp_Trsf mat;
mat.SetTranslation(vec); mat.SetTranslation(vec);
BRepBuilderAPI_Transform mkTransform(mkOffset.Shape(),mat); BRepBuilderAPI_Transform mkTransform(mkOffset.Shape(),mat);
wire_list.push_back(TopoDS::Wire(mkTransform.Shape())); if (mkTransform.Shape().IsNull())
Standard_Failure::Raise("Tapered shape is empty");
TopAbs_ShapeEnum type = mkTransform.Shape().ShapeType();
if (type == TopAbs_WIRE) {
wire_list.push_back(TopoDS::Wire(mkTransform.Shape()));
}
else if (type == TopAbs_EDGE) {
BRepBuilderAPI_MakeWire mkWire(TopoDS::Edge(mkTransform.Shape()));
wire_list.push_back(mkWire.Wire());
}
else {
Standard_Failure::Raise("Tapered shape type is not supported");
}
BRepOffsetAPI_ThruSections mkGenerator(makeSolid ? Standard_True : Standard_False, Standard_False); BRepOffsetAPI_ThruSections mkGenerator(makeSolid ? Standard_True : Standard_False, Standard_False);
for (std::list<TopoDS_Wire>::const_iterator it = wire_list.begin(); it != wire_list.end(); ++it) { for (std::list<TopoDS_Wire>::const_iterator it = wire_list.begin(); it != wire_list.end(); ++it) {
@ -139,6 +157,8 @@ App::DocumentObjectExecReturn *Extrusion::execute(void)
TopoDS_Shape myShape = base->Shape.getValue(); TopoDS_Shape myShape = base->Shape.getValue();
if (myShape.IsNull()) if (myShape.IsNull())
Standard_Failure::Raise("Cannot extrude empty shape"); Standard_Failure::Raise("Cannot extrude empty shape");
// #0000910: Circles Extrude Only Surfaces, thus use BRepBuilderAPI_Copy
myShape = BRepBuilderAPI_Copy(myShape).Shape();
if (makeSolid && myShape.ShapeType() == TopAbs_WIRE) { if (makeSolid && myShape.ShapeType() == TopAbs_WIRE) {
BRepBuilderAPI_MakeFace mkFace(TopoDS::Wire(myShape)); BRepBuilderAPI_MakeFace mkFace(TopoDS::Wire(myShape));
myShape = mkFace.Face(); myShape = mkFace.Face();