Not working properly on realthunder's fork #10

New Issue

2022-03-07T10:28:54Z

m1pro commented

2022-03-07 10:28:54 +00:00

(Migrated from github.com)

creates a mess.
re-add the widget on every switch between workbench and steals focus each time.

creates a mess. re-add the widget on every switch between workbench and steals focus each time.

m1pro commented

2022-03-07 11:24:37 +00:00

(Migrated from github.com)

with my very limited knowledge in writing addons I've managed to fix it but better that a pro will review and merge:

I've updated InitGui.py to be:

# Avoid garbage collection by storing the action in a global variable                                                    
wax = None                                                                                                               
sea = None                                                                                                               
tbr = None                                                                                                               
                                                                                                                         
def addToolSearchBox():                                                                                                  
  import FreeCADGui                                                                                                      
  from PySide import QtGui                                                                                               
  import SearchBoxLight                                                                                                  
  global wax, sea, tbr                                                                                                   
  mw = FreeCADGui.getMainWindow()                                                                                        
  if mw:                                                                                                                 
    if sea is None:                                                                                                      
        sea = SearchBoxLight.SearchBoxLight(getItemGroups   = lambda: __import__('GetItemGroups').getItemGroups(),       
                                            getToolTip      = lambda groupId, setParent: __import__('GetItemGroups').getToolTip(groupId, setParent), 
                                            getItemDelegate = lambda: __import__('IndentedItemDelegate').IndentedItemDelegate()) 
        sea.resultSelected.connect(lambda index, groupId: __import__('GetItemGroups').onResultSelected(index, groupId))  
                                                                                                                         
    if wax is None:                                                                                                      
        wax = QtGui.QWidgetAction(None)                                                                                  
        wax.setWhatsThis('Use this search bar to find tools, document objects, preferences and more')                    
                                                                                                                         
    sea.setWhatsThis('Use this search bar to find tools, document objects, preferences and more')                        
    wax.setDefaultWidget(sea)                                                                                            
    ##mbr.addWidget(sea)                                                                                                 
    #mbr.addAction(wax)                                                                                                  
    if tbr is None:                                                                                                      
        tbr = QtGui.QToolBar("SearchBar") #QtGui.QDockWidget()                                                           
        # Include FreeCAD in the name so that one can find windows labeled with FreeCAD easily in window managers which allow search through the list of open windows.
        tbr.setObjectName("SearchBar")                                                                                   
        tbr.addAction(wax)                                                                                               
    mw.addToolBar(tbr)                                                                                                   
    tbr.show()                                                                                                           
                                                                                                                         
                                                                                                                         
addToolSearchBox()                                                                                                       
import FreeCADGui                                                                                                        
FreeCADGui.getMainWindow().workbenchActivated.connect(addToolSearchBox)

with my very limited knowledge in writing addons I've managed to fix it but better that a pro will review and merge: I've updated InitGui.py to be: ```python # Avoid garbage collection by storing the action in a global variable wax = None sea = None tbr = None def addToolSearchBox(): import FreeCADGui from PySide import QtGui import SearchBoxLight global wax, sea, tbr mw = FreeCADGui.getMainWindow() if mw: if sea is None: sea = SearchBoxLight.SearchBoxLight(getItemGroups = lambda: __import__('GetItemGroups').getItemGroups(), getToolTip = lambda groupId, setParent: __import__('GetItemGroups').getToolTip(groupId, setParent), getItemDelegate = lambda: __import__('IndentedItemDelegate').IndentedItemDelegate()) sea.resultSelected.connect(lambda index, groupId: __import__('GetItemGroups').onResultSelected(index, groupId)) if wax is None: wax = QtGui.QWidgetAction(None) wax.setWhatsThis('Use this search bar to find tools, document objects, preferences and more') sea.setWhatsThis('Use this search bar to find tools, document objects, preferences and more') wax.setDefaultWidget(sea) ##mbr.addWidget(sea) #mbr.addAction(wax) if tbr is None: tbr = QtGui.QToolBar("SearchBar") #QtGui.QDockWidget() # Include FreeCAD in the name so that one can find windows labeled with FreeCAD easily in window managers which allow search through the list of open windows. tbr.setObjectName("SearchBar") tbr.addAction(wax) mw.addToolBar(tbr) tbr.show() addToolSearchBox() import FreeCADGui FreeCADGui.getMainWindow().workbenchActivated.connect(addToolSearchBox) ```

SuzanneSoy commented

2022-03-12 19:32:23 +00:00

(Migrated from github.com)

Your patch seems perfect, thanks! Applied it in 61037da9ac

There's still a minor issue, the 3D preview doesn't seem to center the shape correctly :-/ so I opened a separate issue here https://github.com/SuzanneSoy/SearchBar/issues/11

Your patch seems perfect, thanks! Applied it in https://github.com/SuzanneSoy/SearchBar/commit/61037da9acaf9c4f41f9a54be1733cd89e445dcf There's still a minor issue, the 3D preview doesn't seem to center the shape correctly :-/ so I opened a separate issue here https://github.com/SuzanneSoy/SearchBar/issues/11

Sign in to join this conversation.