suzanne.soy/delay-pure
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Temporary hack: allow unsafe-undefined

Browse Source 
We should really roll our own optional-arguments mechanism, to prevent that value from causing issues
This commit is contained in:
Georges Dupéron 2018-06-03 00:33:48 +02:00
parent 06407a46e3
commit 559e5b7075
2 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
private/pure-function.rkt
View File

@ -8,6 +8,7 @@
(only-in typed/racket/unsafe unsafe-require/typed) (only-in typed/racket/unsafe unsafe-require/typed)
(prefix-in te: type-expander) (prefix-in te: type-expander)
phc-toolkit phc-toolkit
version-case
(for-syntax (rename-in racket/base [... …]) (for-syntax (rename-in racket/base [... …])
racket/match racket/match
syntax/modcollapse syntax/modcollapse
@ -21,6 +22,12 @@
phc-toolkit/untyped phc-toolkit/untyped
"fully-expanded-grammar-no-set.rkt")) "fully-expanded-grammar-no-set.rkt"))
(version-case
[(version< (version) "6.90.0.29")
(begin)]
[else
(require racket/unsafe/undefined)])
(unsafe-require/typed (unsafe-require/typed
"pure-unsafe.rkt" "pure-unsafe.rkt"
[promise/pure/maybe-stateful? (→ Any Boolean : Promise)] [promise/pure/maybe-stateful? (→ Any Boolean : Promise)]
@ -221,6 +228,15 @@
;; To allow pure functions which return pure functions, we need to allow ;; To allow pure functions which return pure functions, we need to allow
;; check-immutable/c itself ;; check-immutable/c itself
[(eq? x check-immutable/error) #t] [(eq? x check-immutable/error) #t]
;; racket/unsafe/undefined is used in the expanded code for functions with
;; opetional arguments. We allow it here (for now), even though it is
;; unsafe, because the user (or a library) would need to explicitly require
;; it to cause problems. Otherwise, it will only appear in code generated by
;; typed/racket.
[(version-case
[(version< (version) "6.90.0.29") #f]
[else (eq? x unsafe-undefined)])
#t]
;; Otherwise, fail early before mutation causes problems ;; Otherwise, fail early before mutation causes problems
[else (begin (other) #f)])) [else (begin (other) #f)]))

10
test/test-external-mutation.rkt
View File

@ -4,7 +4,6 @@
;; This file checks that externally mutating a free variable on which a pure ;; This file checks that externally mutating a free variable on which a pure
;; function or promise depends does not affect the function's result. ;; function or promise depends does not affect the function's result.
(check-equal? (let ([x 1]) (check-equal? (let ([x 1])
(define d (delay/pure/stateful (add1 x))) (define d (delay/pure/stateful (add1 x)))
(list (begin (set! x -10) (force d)) (list (begin (set! x -10) (force d))
@ -78,4 +77,11 @@
(define-pure/stateful (d #:kw [opt : Number x]) (add1 opt)) (define-pure/stateful (d #:kw [opt : Number x]) (add1 opt))
(list (begin (set! x -10) (d)) (list (begin (set! x -10) (d))
(begin (set! x -11) (d)))) (begin (set! x -11) (d))))
'(2 2)) '(2 2))
;; Check that this doesn't cause a run-time error due to the internal use of
;; unsafe-undefined in the expanded function with optional arguments (starting
;; from Racket 6.90.0.29)
(define z 1)
(define-pure/stateless (d [opt : Number z]) (void))
(d)