From 2ba8229d23ecfaab193bcc5029d4f6ecb2c806ad Mon Sep 17 00:00:00 2001 From: larabr Date: Mon, 18 Sep 2023 14:14:49 +0200 Subject: [PATCH] Fix CFB decryption performance in JS fallback for ciphers other than AES (#1679) This issue affected non-AES ciphers (legacy), such as Cast5, in Node 18+ and in browser. --- src/crypto/mode/cfb.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/crypto/mode/cfb.js b/src/crypto/mode/cfb.js index 6f09becf..e16f88b6 100644 --- a/src/crypto/mode/cfb.js +++ b/src/crypto/mode/cfb.js @@ -119,7 +119,7 @@ export async function decrypt(algo, key, ciphertext, iv) { let j = 0; while (chunk ? ct.length >= block_size : ct.length) { const decblock = cipherfn.encrypt(blockp); - blockp = ct; + blockp = ct.subarray(0, block_size); for (i = 0; i < block_size; i++) { plaintext[j++] = blockp[i] ^ decblock[i]; }