suzanne.soy/fork-openpgpjs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix verification of EdDSA signatures with short MPIs (#1083)

Browse Source 
We would fail to verify EdDSA signatures with leading zeros, when
encoded according to the spec (without leading zeros, leading to
short MPIs). OpenPGP.js itself encodes them with leading zeros.
This is accepted by many implementations, but not valid according
to the spec. We will fix that in a future version.
This commit is contained in:
Daniel Huigens 2020-04-16 17:03:49 +02:00 committed by GitHub
parent b69d0d0228
commit 90ff60cbb1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/type/mpi.js
View File

@ -98,16 +98,11 @@ MPI.prototype.toUint8Array = function (endian, length) {
length = length || this.data.length;
const payload = new Uint8Array(length);
const start = length - this.data.length;
if (start < 0) {
throw new Error('Payload is too large.');
}
const start = endian === 'le' ? 0 : length - this.data.length;
payload.set(this.data, start);
if (endian === 'le') {
payload.reverse();
}
return payload;
};