Cleanup public api
This commit is contained in:
parent
1e3d6468d6
commit
ddedb5cb42
|
@ -109,18 +109,7 @@ export function generateKey({ userIds=[], passphrase, numBits=2048, unlocked=fal
|
||||||
privateKeyArmored: newKey.armor(),
|
privateKeyArmored: newKey.armor(),
|
||||||
publicKeyArmored: newKey.toPublic().armor()
|
publicKeyArmored: newKey.toPublic().armor()
|
||||||
|
|
||||||
})).catch(err => {
|
})).catch(onError.bind(null, 'Error generating keypair'));
|
||||||
|
|
||||||
// js fallback already tried
|
|
||||||
if (config.debug) { console.error(err); }
|
|
||||||
if (!util.getWebCryptoAll()) {
|
|
||||||
throw new Error('Error generating keypair using js fallback');
|
|
||||||
}
|
|
||||||
// fall back to js keygen in a worker
|
|
||||||
if (config.debug) { console.log('Error generating keypair using native WebCrypto... falling back back to js'); }
|
|
||||||
return asyncProxy.delegate('generateKey', options);
|
|
||||||
|
|
||||||
}).catch(onError.bind(null, 'Error generating keypair'));
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -173,14 +162,15 @@ export function encrypt({ data, publicKeys, privateKeys, passwords, filename, ar
|
||||||
return asyncProxy.delegate('encrypt', { data, publicKeys, privateKeys, passwords, filename, armor });
|
return asyncProxy.delegate('encrypt', { data, publicKeys, privateKeys, passwords, filename, armor });
|
||||||
}
|
}
|
||||||
|
|
||||||
return new Promise(resolve => {
|
return new Promise(resolve => resolve()).then(() => {
|
||||||
|
|
||||||
let message = createMessage(data, filename);
|
let message = createMessage(data, filename);
|
||||||
if (privateKeys) { // sign the message only if private keys are specified
|
if (privateKeys) { // sign the message only if private keys are specified
|
||||||
message = message.sign(privateKeys);
|
message = message.sign(privateKeys);
|
||||||
}
|
}
|
||||||
resolve(message);
|
return message.encrypt(publicKeys, passwords);
|
||||||
|
|
||||||
}).then(message => message.encrypt(publicKeys, passwords)).then(message => {
|
}).then(message => {
|
||||||
|
|
||||||
if(armor) {
|
if(armor) {
|
||||||
return {
|
return {
|
||||||
|
|
|
@ -339,25 +339,6 @@ describe('OpenPGP.js public api tests', function() {
|
||||||
expect(proxyGenStub.calledOnce).to.be.true;
|
expect(proxyGenStub.calledOnce).to.be.true;
|
||||||
expect(keyGenStub.calledOnce).to.be.false;
|
expect(keyGenStub.calledOnce).to.be.false;
|
||||||
});
|
});
|
||||||
|
|
||||||
it('should delegate to async proxy after web crypto failure', function(done) {
|
|
||||||
var workerStub = {
|
|
||||||
postMessage: function() {}
|
|
||||||
};
|
|
||||||
openpgp.initWorker({
|
|
||||||
worker: workerStub
|
|
||||||
});
|
|
||||||
var proxyGenStub = sinon.stub(openpgp.getWorker(), 'delegate').returns(resolves('proxy_key'));
|
|
||||||
getWebCryptoAllStub.returns({});
|
|
||||||
keyGenStub.returns(rejects(new Error('Native webcrypto keygen failed on purpose :)')));
|
|
||||||
|
|
||||||
openpgp.generateKey().then(function(newKey) {
|
|
||||||
expect(keyGenStub.calledOnce).to.be.true;
|
|
||||||
expect(proxyGenStub.calledOnce).to.be.true;
|
|
||||||
expect(newKey).to.equal('proxy_key');
|
|
||||||
done();
|
|
||||||
});
|
|
||||||
});
|
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('generateKey - integration tests', function() {
|
describe('generateKey - integration tests', function() {
|
||||||
|
|
Loading…
Reference in New Issue
Block a user