suzanne.soy/hyper-literate
1
0
Fork 0
Code Issues 4 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

search box: change '"s" for search' behavior (#202)

Browse Source 
1. Focus on the search box for either "s" or "S"
   ... accepting only "s" makes sense to me, but the comment said it
   accepted "S" and well why not
2. Look for a "keyup" event instead of key press, so that pressing "s"
   ONLY focuses on the box and does not focus-and-write-the-letter-"s"

"keyup" events apparently don't have a useful `charCode` field so this
PR looks at the `keyCode` field instead
This commit is contained in:
Ben Greenman 2019-05-01 23:35:18 -04:00 committed by GitHub
parent 441e97ec27
commit 7635f21788
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scribble-lib/scribble/scribble-common.js
View File

@ -169,10 +169,10 @@ AddOnLoad(function(){
indicator.style.display = "block";
});
// Pressing "S" focuses on the "...search manuals..." text field
// Pressing "S" or "s" focuses on the "...search manuals..." text field
AddOnLoad(function(){
window.addEventListener("keypress", function(event) {
if (event && event.charCode == 115 && event.target == document.body) {
window.addEventListener("keyup", function(event) {
if (event && (event.keyCode == 83 || event.keyCode == 115) && event.target == document.body) {
var field = document.getElementsByClassName("searchbox")[0];
field.focus();
}