suzanne.soy/hyper-literate
1
0
Fork 0
Code Issues 4 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Refactor search placeholder

Browse Source 
HTML supports the placeholder attribute, so we should use it
instead of implementing it ourselves.

The placeholder attribute is not available prior IE10 (not including
IE10). However:

1. In non-supporting browsers (e.g., IE9), the search functionality
should still work correctly.
2. Non-supporting browsers don't qualify for the "full support" level
detailed in https://github.com/racket/scribble/pull/240/
IE9 for instance is released in 2011, and Microsoft announced its end of
support in 2016.
This commit is contained in:
Sorawee Porncharoenwase 2020-09-28 18:03:34 -07:00 committed by Matthew Flatt
parent dc3254303d
commit c054b62765
2 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
scribble-lib/scribble/html-render.rkt
View File

@ -221,26 +221,16 @@
(string->symbol (alt-tag-name s))))) (string->symbol (alt-tag-name s)))))
(define (make-search-box top-path) ; appears on every page (define (make-search-box top-path) ; appears on every page
(let ([sa string-append] (let ([emptylabel "...search manuals..."])
[emptylabel "...search manuals..."]
[dimcolor "#888"])
`(form ([class "searchform"]) `(form ([class "searchform"])
(input (input
([class "searchbox"] ([class "searchbox"]
[style ,(sa "color: "dimcolor";")]
[type "text"] [type "text"]
[tabindex "1"] [tabindex "1"]
[value ,emptylabel] [placeholder ,emptylabel]
[title "Enter a search string to search the manuals"] [title "Enter a search string to search the manuals"]
[onkeypress ,(format "return DoSearchKey(event, this, ~s, ~s);" [onkeypress ,(format "return DoSearchKey(event, this, ~s, ~s);"
(version) top-path)] (version) top-path)])))))
[onfocus ,(sa "this.style.color=\"black\"; "
"this.style.textAlign=\"left\"; "
"if (this.value == \""emptylabel"\") this.value=\"\";")]
[onblur ,(sa "if (this.value.match(/^ *$/)) {"
" this.style.color=\""dimcolor"\";"
" this.style.textAlign=\"center\";"
" this.value=\""emptylabel"\"; }")])))))
(define search-box (make-search-box "../")) (define search-box (make-search-box "../"))
(define top-search-box (make-search-box "")) (define top-search-box (make-search-box ""))

5
scribble-lib/scribble/scribble.css
View File

@ -152,10 +152,13 @@ table td {
padding: 0px; padding: 0px;
background-color: #eee; background-color: #eee;
border: 1px solid #ddd; border: 1px solid #ddd;
text-align: center;
vertical-align: middle; vertical-align: middle;
} }
.searchbox::placeholder {
text-align: center;
}
#contextindicator { #contextindicator {
position: fixed; position: fixed;
background-color: #c6f; background-color: #c6f;