suzanne.soy/hyper-literate
1
0
Fork 0
Code Issues 4 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Use key instead of keyCode

Browse Source 
In non QWERTY keyboard, pressing S won't focus the search bar.
This commit fixes the problem.

Note that `keyCode` is not supported in IE8 already, so the fact
that `key` is not supported in IE8 too doesn't really matter:
the PR doesn't cause browser compatibility for the features to degrade.
This commit is contained in:
sorawee 2020-11-06 07:55:50 -08:00 committed by GitHub
parent b3f7015cba
commit dc3254303d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scribble-lib/scribble/scribble-common.js
View File

@ -129,7 +129,7 @@ function NormalizePath(path) {
function DoSearchKey(event, field, ver, top_path) { function DoSearchKey(event, field, ver, top_path) {
var val = field.value; var val = field.value;
if (event && event.keyCode == 13) { if (event && event.key === 'Enter') {
var u = GetCookie("PLT_Root."+ver, null); var u = GetCookie("PLT_Root."+ver, null);
if (u == null) u = top_path; // default: go to the top path if (u == null) u = top_path; // default: go to the top path
u += "search/index.html?q=" + encodeURIComponent(val); u += "search/index.html?q=" + encodeURIComponent(val);
@ -171,8 +171,8 @@ AddOnLoad(function(){
// Pressing "S" or "s" focuses on the "...search manuals..." text field // Pressing "S" or "s" focuses on the "...search manuals..." text field
AddOnLoad(function(){ AddOnLoad(function(){
window.addEventListener("keyup", function(event) { window.addEventListener("keyup", function(e) {
if (event && (event.keyCode == 83 || event.keyCode == 115) && event.target == document.body) { if ((e.key === 's' || e.key === 'S') && e.target === document.body) {
var field = document.getElementsByClassName("searchbox")[0]; var field = document.getElementsByClassName("searchbox")[0];
field.focus(); field.focus();
} }