Fixes bug #44 (Re-provided identifiers are not tracked across submodules)

The current expader's `namespace-require` has a bug that prevents
it from reporting a conclict when `(for-label <lib>)` creates
a conflict due to different provided bindings of the same name
at different phases from <lib>. Avoid depending on that bug.

scribble-doc/scribblings/scribble/jfp.scrbl

@@ -55,3 +55,19 @@ If different authors have different affiliations, use
 use @racket[affiliation-mark] before each different affiliation within
 a single @racket[affiliation], using @racket[(affiliation-sep)] to
 separate affiliations.}
+
+Examples:
+@codeblock|{
+#lang scribble/jfp
+
+@title{My First Love Story}
+
+@((author/short "Romeo M. and Juliet C.")
+  "ROMEO" (affiliation-mark "1")
+  " and "
+  "JULIET" (affiliation-mark "2")
+  @affiliation[
+    "House Montague" (affiliation-mark "1")
+    (affiliation-sep)
+    "House Capulet" (affiliation-mark "2")])
+}|

scribble-doc/scribblings/scribble/manual.scrbl

@@ -1949,6 +1949,28 @@ produced by @racket[content-expr] should normally start with a capital
 letter and end with a period, but it can be a sentence fragment such
 as ``Added a @racket[#:changed] form.''
 
+Examples:
+@codeblock[#:keep-lang-line? #f]|{
+#lang scribble/manual
+@defthing[tasty-burrito burrito?]{
+  Compatible with the API of a sandwich, but not legally a
+  sandwich in Massachusetts.
+
+  @history[#:added "1.0"
+           #:changed "1.1" "Refactored tortilla."
+           #:changed "1.2" @elem{Now includes @emph{guacamole}.}]
+}
+}|
+@doc-render-examples[
+  @defthing[tasty-burrito burrito?]{
+    Compatible with the API of a sandwich, but not legally a
+    sandwich in Massachusetts.
+
+    @history[#:added "1.0"
+             #:changed "1.1" "Refactored tortilla."
+             #:changed "1.2" @elem{Now includes @emph{guacamole}.}]
+}]
+
 @history[#:added "1.1"]}
 
 @; ------------------------------------------------------------------------
@@ -2049,6 +2071,16 @@ rendered document.}
 Indicates that the index entry corresponds to a module definition via
 @racket[defmodule] and company.}
 
+@deftogether[(
+@defstruct[(language-index-desc module-path-index-desc) ()]{}
+@defstruct[(reader-index-desc module-path-index-desc) ()]{}
+)]{
+Indicates that the index entry corresponds to a module definition via
+@racket[defmodule] with the @racket[#:lang] or @racket[#:reader] option.
+For example, a module definition via @racket[defmodulelang] has a
+@racket[language-index-desc] index entry and a module definition via
+@racket[defmodulereader] has a @racket[reader-index-desc] index entry.}
+
 @defstruct[exported-index-desc ([name symbol?]
                                [from-libs (listof module-path?)])]{
 

scribble-lib/scribble/elsarticle/.gitignore

@@ -0,0 +1,2 @@
+# to avoid committing it by accident, since we can't distribute it
+/elsarticle.cls

scribble-lib/scribble/elsarticle/elsarticle.tex

@@ -0,0 +1,5 @@
+\newcommand{\ELSauthor}[1]{\author{#1}}
+\newcommand{\ELSaddress}[1]{\address{#1}}
+\newcommand{\ELSemail}[1]{\ead{#1}}
+
+\newcommand{\ELSabstract}[1]{\begin{abstract}#1\end{abstract}}

scribble-lib/scribble/elsarticle/lang.rkt

@@ -0,0 +1,68 @@
+#lang racket/base
+(require scribble/doclang
+         scribble/core
+         racket/file
+         (except-in scribble/base author)
+         (prefix-in s/b: scribble/base)
+         scribble/decode
+         "../private/defaults.rkt"
+         setup/collects
+         scribble/html-properties
+         scribble/latex-properties
+         scribble/latex-prefix
+         racket/stxparam
+         net/ftp
+         file/gunzip
+         (for-syntax racket/base
+                     racket/list
+                     racket/stxparam-exptime))
+
+(module test racket/base)
+
+(provide (except-out (all-from-out scribble/doclang) #%module-begin)
+         (all-from-out scribble/base)
+         (rename-out [module-begin #%module-begin])
+         frontmatter
+         abstract author email address)
+
+(define-syntax (module-begin stx)
+  ;; No options, currently, but keep in case we want to support some:
+  (syntax-case* stx () (lambda (a b) (eq? (syntax-e a) (syntax-e b)))
+    [(_ id ws . body)
+     ;; Skip intraline whitespace to find options:
+     (and (string? (syntax-e #'ws))
+          (regexp-match? #rx"^ *$" (syntax-e #'ws)))
+     #'(module-begin id . body)]
+    [(_ id . body)
+     #'(#%module-begin id (post-process) () . body)]))
+
+(define ((post-process) doc)
+  (add-defaults doc
+                (string->bytes/utf-8 (string-append "\\documentclass{elsarticle}\n"
+                                                    unicode-encoding-packages))
+                (scribble-file "elsarticle/style.tex")
+                '()
+                #f))
+
+(define elsarticle-extras
+  (let ([abs (lambda (s)
+               (path->collects-relative
+                (collection-file-path s "scribble" "elsarticle")))])
+    (list
+     (make-tex-addition (abs "elsarticle.tex")))))
+
+(define (LaTeX-element i)
+  (λ strs
+    (make-element (style i elsarticle-extras)
+                  ;; XXX maybe decode-content
+                  (decode-content strs))))
+
+(define abstract (LaTeX-element "ELSabstract"))
+(define author (LaTeX-element "ELSauthor"))
+(define address (LaTeX-element "ELSaddress"))
+(define email (LaTeX-element "ELSemail"))
+
+(define (frontmatter #:authors as
+                     #:abstract a)
+  (paragraph (style 'author '())
+             (append as (list a))))

scribble-lib/scribble/elsarticle/lang/reader.rkt

@@ -0,0 +1,3 @@
+#lang s-exp scribble/base/reader
+scribble/elsarticle/lang
+#:wrapper1 (lambda (t) (cons 'doc (t)))

scribble-lib/scribble/elsarticle/style.tex

@@ -0,0 +1,3 @@
+
+\renewcommand{\titleAndVersionAndAuthors}[3]{\begin{frontmatter}\title{#1}#3\end{frontmatter}}
+\renewcommand{\titleAndEmptyVersionAndAuthors}[3]{\titleAndVersionAndAuthors{#1}{#1}{#3}}

scribble-lib/scribble/manual-struct.rkt

@@ -5,6 +5,8 @@
 
 (provide-structs
  [module-path-index-desc ()]
+ [(language-index-desc module-path-index-desc) ()]
+ [(reader-index-desc module-path-index-desc) ()]
  [exported-index-desc ([name symbol?]
                        [from-libs (listof module-path?)])]
  [(method-index-desc exported-index-desc) ([method-name symbol?]

scribble-lib/scribble/private/manual-bind.rkt

@@ -114,7 +114,15 @@
                                 (let ([ns-id 
                                        (let ([ns (make-base-empty-namespace)])
                                          (parameterize ([current-namespace ns])
-                                           (namespace-require `(for-label ,lib))
+                                           ;; A `(namespace-require `(for-label ,lib))` can
+                                           ;; fail if `lib` provides different bindings of the
+                                           ;; same name at different phases. We can require phases
+                                           ;; 1 and 0 separately, in which case the phase-0
+                                           ;; binding shadows the phase-1 one in that case.
+                                           ;; This strategy only works for documenting bindings
+                                           ;; at phases 0 and 1, though.
+                                           (namespace-require `(just-meta 1 (for-label ,lib)))
+                                           (namespace-require `(just-meta 0 (for-label ,lib)))
                                            (namespace-syntax-introduce (datum->syntax #f 'x))))])
                                   (let ([checker
                                          (lambda (id)

scribble-lib/scribble/private/manual-mod.rkt

@@ -221,30 +221,36 @@
                                    (add-between (map tt pkgs) ", "))))))))))
     (define (flow-width f) (apply max (map block-width f)))
     (define libs-specs
+      ;; make-desc  : element -> flow
+      ;; index-desc : module-path-index-desc
+      (let-values ([(make-desc index-desc)
+                    (case lang
+                      [(#f)
+                       (values (lambda (modname) (list (racket (#,req #,modname))))
+                               the-module-path-index-desc)]
+                      [(#t)
+                       (values (lambda (modname) (list (hash-lang) spacer modname))
+                               the-language-index-desc)]
+                      [(reader)
+                       (values (lambda (modname) (list (racketmetafont "#reader") spacer modname))
+                               the-reader-index-desc)]
+                      [(just-lang)
+                       (values (lambda (modname) (list (hash-lang) spacer modname))
+                               the-language-index-desc)]
+                      [else (error 'defmodule "unknown mode: ~e" lang)])])
       (map
        (lambda (name modpath)
          (define modname (if link-target?
-                             (make-defracketmodname name modpath)
+                             (make-defracketmodname name modpath index-desc)
                              name))
          (list
           (make-flow
            (list
             (make-omitable-paragraph
-             (cons
+             (cons spacer (make-desc modname)))))
-              spacer
-              (case lang
-                [(#f)
-                 (list (racket (#,req #,modname)))]
-                [(#t)
-                 (list (hash-lang) spacer modname)]
-                [(reader)
-                 (list (racketmetafont "#reader") spacer modname)]
-                [(just-lang)
-                 (list (hash-lang) spacer modname)]
-                [else (error 'defmodule "unknown mode: ~e" lang)])))))
           'cont))
        names
-       modpaths))
+       modpaths)))
 
     (make-splice
      (cons
@@ -278,8 +284,10 @@
               (flow-paragraphs (decode-flow content)))))))
 
 (define the-module-path-index-desc (make-module-path-index-desc))
+(define the-language-index-desc (make-language-index-desc))
+(define the-reader-index-desc (make-reader-index-desc))
 
-(define (make-defracketmodname mn mp)
+(define (make-defracketmodname mn mp index-desc)
   (let ([name-str (datum-intern-literal (element->string mn))]
         [path-str (datum-intern-literal (element->string mp))])
     (make-index-element #f
@@ -287,7 +295,7 @@
                         (intern-taglet `(mod-path ,path-str))
                         (list name-str)
                         (list mn)
-                        the-module-path-index-desc)))
+                        index-desc)))
 
 (define-syntax (declare-exporting stx)
   (syntax-parse stx

scribble-lib/scribble/search.rkt

@@ -92,7 +92,8 @@
                                 (let ([v (resolve-get/tentative part ri `(form ,eb))])
                                   (or (and v `(form ,eb))
                                       `(def ,eb))))]
-                          [need-result? (and need-result? (not here-result))])
+                          [need-result? (and need-result? (not here-result))]
+                          [rmp-name (resolved-module-path-name rmp)])
                      ;; Even if we've found `here-result', look deeper so that we have 
                      ;; consistent `dep' results.
                      (let ([nest-result
@@ -102,7 +103,9 @@
                                 ;; Not defined through this path, so keep looking
                                 (loop queue rqueue need-result?)
                                 ;; Check parents, if we can get the source:
-                                (if (and (path? (resolved-module-path-name rmp))
+                                (if (and (or (path? rmp-name)
+                                             (and (list? rmp-name)
+                                                  (path? (car rmp-name))))
                                          (not (hash-ref seen (cons export-phase rmp) #f)))
                                     (let ([exports
                                            (hash-ref
@@ -114,7 +117,12 @@
                                                              (lambda ()
                                                                ;; First, try using bytecode:
                                                                (module-compiled-exports 
-                                                                (get-module-code (resolved-module-path-name rmp)
+                                                                (get-module-code (if (list? rmp-name)
+                                                                                     (car rmp-name)
+                                                                                     rmp-name)
+                                                                                 #:submodule-path (if (list? rmp-name)
+                                                                                                      (cdr rmp-name)
+                                                                                                      '())
                                                                                  #:choose (lambda (src zo so) 'zo))))
                                                              (lambda ()
                                                                (try