suzanne.soy/lens
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix possible loops with fallback methods

Browse Source 
These would come up if someone defined a struct that declared only
lens-view or only lens-set, or no methods at all.
This commit is contained in:
AlexKnauth 2015-09-24 15:17:51 -04:00
parent 69dcc57a21
commit 57b5d417da
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lens/private/base/gen-lens.rkt
View File

@ -19,15 +19,24 @@
(lens-view lens target) (lens-view lens target)
(lens-set lens target x) (lens-set lens target x)
(focus-lens lens target) (focus-lens lens target)
#:defined-predicate lens-implements?
#:fallbacks #:fallbacks
[(define/generic gen-lens-view lens-view) [(define/generic gen-lens-view lens-view)
(define/generic gen-lens-set lens-set) (define/generic gen-lens-set lens-set)
(define/generic gen-focus-lens focus-lens)
(define (lens-view lens target) (define (lens-view lens target)
(let-lens (view _) lens target view)) (unless (lens-implements? lens 'focus-lens)
(error 'lens-view "not implemented for ~v" lens))
(let-values ([(view _) (gen-focus-lens lens target)])
view))
(define (lens-set lens target x) (define (lens-set lens target x)
(let-lens (_ setter) lens target (unless (lens-implements? lens 'focus-lens)
(error 'lens-set "not implemented for ~v" lens))
(let-values ([(_ setter) (gen-focus-lens lens target)])
(setter x))) (setter x)))
(define (focus-lens lens target) (define (focus-lens lens target)
(unless (lens-implements? lens 'lens-view 'lens-set)
(error 'focus-lens "not implemented for ~v" lens))
(values (gen-lens-view lens target) (values (gen-lens-view lens target)
(gen-lens-set lens target _)))] (gen-lens-set lens target _)))]
#:derive-property prop:procedure #:derive-property prop:procedure