From 03dc493c4111d98ce9611aa730a7e48eab4ae532 Mon Sep 17 00:00:00 2001 From: Eli Barzilay Date: Sun, 15 Nov 2009 08:03:27 +0000 Subject: [PATCH] few more comments svn: r16776 original commit: d3b5d8f71efe641d1f4aa42558957c89309121fb --- collects/unstable/find.ss | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/collects/unstable/find.ss b/collects/unstable/find.ss index 51d0a93..3fc197e 100644 --- a/collects/unstable/find.ss +++ b/collects/unstable/find.ss @@ -54,7 +54,10 @@ (for/fold ([acc acc]) ([elem (in-list xs)]) (loop elem acc))) (reverse (loop x null))) - +;; Eli: This looks borderline too generic to be useful, also in the fact that +;; the documentation tends to explain things in terms of the implementation +;; (eg, the description of #:stop). In any case, you should definitely +;; rename it -- `find' is too common in different ways (see srfi-1 or cltl). (define (find-first pred x #:stop [stop #f] @@ -67,3 +70,4 @@ (if (procedure? default) (default) default))) +;; Eli: Note that this is documented "Like `find-first'".