suzanne.soy/nixpkgs
1
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

srcOnly: rename buildInputs to nativeBuildInputs

Browse Source 
The only reason to pass build inputs is to extend the unpackPhase with
custom unpack commands. Eg: add "unrar" to unpack rar sources. And those
should really be passed as native build inputs. Why? Because
nativeBuildInputs is for dependencies that are used at build time but
will not propagate as runtime dependencies. And also, cross-compilation.
This commit is contained in:
zimbatm 2020-04-23 11:44:55 +02:00
parent bbbc419186
commit 31ead7d030
No known key found for this signature in database
GPG Key ID: 71BAF6D40C1D63D7
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pkgs/build-support/src-only/default.nix
View File

@ -11,11 +11,21 @@
, src , src
, stdenv ? orig.stdenv , stdenv ? orig.stdenv
, patches ? [] , patches ? []
, buildInputs ? [] , # deprecated, use the nativeBuildInputs
, ... # needed when passing an existing derivation buildInputs ? []
, # used to pass extra unpackers
nativeBuildInputs ? []
, # needed when passing an existing derivation
...
}: }:
stdenv.mkDerivation { stdenv.mkDerivation {
inherit src buildInputs patches name; inherit
buildInputs
name
nativeBuildInputs
patches
src
;
installPhase = "cp -r . $out"; installPhase = "cp -r . $out";
phases = ["unpackPhase" "patchPhase" "installPhase"]; phases = ["unpackPhase" "patchPhase" "installPhase"];
} }