From fca8961bdbb401dd39e4c5f57a3fb96b51d773ab Mon Sep 17 00:00:00 2001 From: Michael Weiss Date: Mon, 23 Mar 2020 19:46:22 +0100 Subject: [PATCH] Revert "chromiumDev: Add the missing clang-format binary" This reverts commit 02ca096a85eced0d653004ae95f7cc6d8597b13e. The clang-format binary is now included in the release tarball [0] and we don't need to add it anymore. This fixes the following build error: ln: failed to create symbolic link 'buildtools/linux64/clang-format': File exists However, the build still fails a bit later in the configure phase. [0]: https://bugs.chromium.org/p/chromium/issues/detail?id=1052503 --- pkgs/applications/networking/browsers/chromium/common.nix | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/pkgs/applications/networking/browsers/chromium/common.nix b/pkgs/applications/networking/browsers/chromium/common.nix index 9d7f529dad6..a5f79805aba 100644 --- a/pkgs/applications/networking/browsers/chromium/common.nix +++ b/pkgs/applications/networking/browsers/chromium/common.nix @@ -7,7 +7,7 @@ , xdg_utils, yasm, minizip, libwebp , libusb1, pciutils, nss, re2, zlib -, python2Packages, perl, pkgconfig, clang-tools +, python2Packages, perl, pkgconfig , nspr, systemd, kerberos , utillinux, alsaLib , bison, gperf @@ -104,8 +104,6 @@ let result else result; - llvm-clang-tools = clang-tools.override { inherit llvmPackages; }; - base = rec { name = "${packageName}-unwrapped-${version}"; inherit (upstream-info) channel version; @@ -218,8 +216,6 @@ let ln -s ${stdenv.cc}/bin/clang third_party/llvm-build/Release+Asserts/bin/clang ln -s ${stdenv.cc}/bin/clang++ third_party/llvm-build/Release+Asserts/bin/clang++ ln -s ${llvmPackages.llvm}/bin/llvm-ar third_party/llvm-build/Release+Asserts/bin/llvm-ar - '' + optionalString (stdenv.lib.versionAtLeast version "82") '' - ln -s ${llvm-clang-tools}/bin/clang-format buildtools/linux64/clang-format ''; gnFlags = mkGnFlags ({