suzanne.soy/qubes-core-agent-linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qrexec-fork-server: Always initialize addrlen argument of accept()

Browse Source 
With the old code the addrlen argument were uninitialized on the first
call resulting in errors depending on the compiler behavior.

(cherry picked from commit f4c402e7c7)
This commit is contained in:
Simon Gaiser 2018-03-15 20:32:27 +01:00 committed by Marek Marczykowski-Górecki
parent 97de92eb57
commit 431eb2dbbb
No known key found for this signature in database
GPG Key ID: 063938BA42CFA724
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
qrexec/qrexec-fork-server.c
View File

@ -105,12 +105,15 @@ int main(int argc, char **argv) {
signal(SIGCHLD, SIG_IGN);
register_exec_func(do_exec);
while ((fd = accept(s, (struct sockaddr *) &peer, &addrlen)) >= 0) {
while (1) {
addrlen = sizeof(peer);
fd = accept(s, (struct sockaddr *) &peer, &addrlen);
if (fd < 0)
break;
if (read_all(fd, &info, sizeof(info))) {
handle_single_command(fd, &info);
}
close(fd);
addrlen = sizeof(peer);
}
close(s);
unlink(socket_path);