From 15388d2d615e76ddef44aa403a68e6b9ed1341f7 Mon Sep 17 00:00:00 2001 From: Miguel Jacq Date: Thu, 25 May 2017 17:50:45 +1000 Subject: [PATCH] reinstate coding style variable line. Fix outlier command formatting in DisposableVM doc --- basics_dev/coding-style.md | 2 ++ services/dvm-impl.md | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/basics_dev/coding-style.md b/basics_dev/coding-style.md index 82d635f5..4e9640ff 100644 --- a/basics_dev/coding-style.md +++ b/basics_dev/coding-style.md @@ -165,6 +165,8 @@ Security coding guidelines height = untrusted_conf.height; ~~~ +- Use others variables, without the `untrusted_` prefix to hold the sanitized values, as shown above. + Python-specific guidelines -------------------------- diff --git a/services/dvm-impl.md b/services/dvm-impl.md index dbb38af1..246580a6 100644 --- a/services/dvm-impl.md +++ b/services/dvm-impl.md @@ -42,7 +42,7 @@ Normally, disposable VM is created when qubes rpc request with target *\$dispvm* 1. modify the savefile so that the VM name, VM UUID, MAC address and IP address are unique 2. restore the COW files from the `saved_cows.tar` 3. create the `/var/run/qubes/fast_block_attach` file, whose presence tells the `/etc/xen/scripts/block` script to bypass some redundant checks and execute as fast as possible. -4. execute "xl restore" in order to restore a domain. +4. execute `xl restore` in order to restore a domain. 5. create the same xenstore keys as normally created when AppVM boots (e.g. `qubes_ip`) 6. create the `qubes_restore_complete` xenstore key. This allows the boot process in DisposableVM to continue.