From 051ca61534fd1668ec191fe1645b6857a7bdb8f6 Mon Sep 17 00:00:00 2001 From: awokd <34515595+awokd@users.noreply.github.com> Date: Sat, 10 Mar 2018 08:13:10 +0000 Subject: [PATCH 1/2] downgrade "recommended" to "you may want" --- configuration/disk-trim.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configuration/disk-trim.md b/configuration/disk-trim.md index bf54f15b..50997baf 100644 --- a/configuration/disk-trim.md +++ b/configuration/disk-trim.md @@ -59,7 +59,7 @@ However, inside App and Template qubes, the `discard` mount option is on by defa If you are using Qubes with LVM, you may also want to set `issue_discards = 1` in `/etc/lvm/lvm.conf`. Setting this option will permit LVM to issue discards to the SSD when logical volumes are shrunk or deleted. -In R4.x, LVM Logical volumes are frequently deleted (every time a disposable VM is shut down, for example) so setting `issue_discards = 1` is recommended if using an SSD. +In R4.x, LVM Logical volumes are frequently deleted (every time a disposable VM is shut down, for example) so you may want to set `issue_discards = 1` if using an SSD, but see the article linked in the first paragraph on this page. However, this is relatively rare in R3.x. From a8ae4b5e5a96bce89397e84294bc4c22a18eff6f Mon Sep 17 00:00:00 2001 From: awokd <34515595+awokd@users.noreply.github.com> Date: Sat, 10 Mar 2018 08:51:18 +0000 Subject: [PATCH 2/2] paragraph -> section --- configuration/disk-trim.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configuration/disk-trim.md b/configuration/disk-trim.md index 50997baf..f176a108 100644 --- a/configuration/disk-trim.md +++ b/configuration/disk-trim.md @@ -59,7 +59,7 @@ However, inside App and Template qubes, the `discard` mount option is on by defa If you are using Qubes with LVM, you may also want to set `issue_discards = 1` in `/etc/lvm/lvm.conf`. Setting this option will permit LVM to issue discards to the SSD when logical volumes are shrunk or deleted. -In R4.x, LVM Logical volumes are frequently deleted (every time a disposable VM is shut down, for example) so you may want to set `issue_discards = 1` if using an SSD, but see the article linked in the first paragraph on this page. +In R4.x, LVM Logical volumes are frequently deleted (every time a disposable VM is shut down, for example) so you may want to set `issue_discards = 1` if using an SSD, but see the article linked in the first section of this page. However, this is relatively rare in R3.x.