From 7d035ef51841565ab5d79547bae365fdc9ccdceb Mon Sep 17 00:00:00 2001 From: Andrew David Wong Date: Sat, 19 Nov 2016 21:28:36 -0800 Subject: [PATCH] Update patch submission instructions * Mention benefits of GitHub PRs * Suggest sending message to qubes-devel in addition to PR * Update link to qubes-devel --- basics_dev/source-code.md | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/basics_dev/source-code.md b/basics_dev/source-code.md index d56b12b6..e33cdfe9 100644 --- a/basics_dev/source-code.md +++ b/basics_dev/source-code.md @@ -57,7 +57,13 @@ If you want to contribute code to the project, there are two ways. Whichever method you choose, you must [sign your code] before it can be accepted. * **Preferred**: Use GitHub's [fork & pull requests]. -* Send a patch to our developer [mailing list] (`git format-patch`). + + Opening a pull request on GitHub greatly eases the code review and tracking + process. In addition, especially for bigger changes, it's a good idea to send + a message to the [qubes-devel mailing list] in order to notify people who + do not receive GitHub notifications. + +* Send a patch to the [qubes-devel mailing list] (`git format-patch`). 1. Make all the changes in your working directory, i.e. edit files, move them around (you can use 'git mv' for this), etc. @@ -77,5 +83,5 @@ method you choose, you must [sign your code] before it can be accepted. [QubesOS GitHub account]: https://github.com/QubesOS/ [sign your code]: /doc/code-signing/ [fork & pull requests]: https://guides.github.com/activities/forking/ -[mailing list]: /doc/mailing-lists/ +[qubes-devel mailing list]: /mailing-lists/#qubes-devel