From baf7fc2a4934492fee0ec7a8f54c85c1749477f9 Mon Sep 17 00:00:00 2001 From: Joanna Rutkowska Date: Wed, 12 May 2010 20:54:28 +0000 Subject: [PATCH] DevelFaq changed How do I submit pathes -- pasted all the instructions here, rather than refering to qubes-devel --- DevelFaq.md | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/DevelFaq.md b/DevelFaq.md index b5db50d3..962a9b0d 100644 --- a/DevelFaq.md +++ b/DevelFaq.md @@ -29,6 +29,22 @@ See [​this message](https://groups.google.com/group/qubes-devel/browse_thread/ ### Q: How do I submit a patch? -See this message: +1. Make all the changes in your working directory, i.e. edit files, move -[​https://groups.google.com/group/qubes-devel/msg/c3f6c50502595424](https://groups.google.com/group/qubes-devel/msg/c3f6c50502595424) +them around (you can use 'git mv' for this), etc. + +1. Add the changes and commit them (git add, git commit). + +Never mix different changes into one commit! + +Write a good description of the commit. The first line should contain a short summary, and then, if you feel like more explanations are needed, enter an empty new line, and then start the long, detailed description (optional). + +1. Test your changes NOW: check if RPMs build fine, etc. + +1. Create the patch using 'git format-patch'. This has an advantage over + +'git diff', because the former will also include your commit message, your name and email, so that \*your\* name will be used as a commit's author. + +1. Send your patch to qubes-devel. Start the message subject with the + +'[PATCH]' string.