From c1f1ee902c0372420dc92f2bb58b4f90a728b969 Mon Sep 17 00:00:00 2001 From: Andrew David Wong Date: Tue, 1 Dec 2020 21:37:45 -0800 Subject: [PATCH] Update image linking syntax; use syntax on same page --- developer/general/doc-guidelines.md | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/developer/general/doc-guidelines.md b/developer/general/doc-guidelines.md index beae2d95..a7998b6e 100644 --- a/developer/general/doc-guidelines.md +++ b/developer/general/doc-guidelines.md @@ -67,42 +67,42 @@ Ok, let's start. Every documentation page has an "Edit this page" button. It may be on the side (in the desktop layout): -![edit-button-desktop](/attachment/wiki/doc-edit/03-button2.png) +[![edit-button-desktop](/attachment/wiki/doc-edit/03-button2.png)](/attachment/wiki/doc-edit/03-button2.png) Or at the bottom (in the mobile layout): -![edit-button-mobile](/attachment/wiki/doc-edit/02-button1.png) +[![edit-button-mobile](/attachment/wiki/doc-edit/02-button1.png)](/attachment/wiki/doc-edit/02-button1.png) When you click on it, you'll be prompted for your GitHub username and password (if you aren't already logged in). You can also create an account from here. -![github-sign-in](/attachment/wiki/doc-edit/04-sign-in.png) +[![github-sign-in](/attachment/wiki/doc-edit/04-sign-in.png)](/attachment/wiki/doc-edit/04-sign-in.png) If this is your first contribution to the documentation, you need to "fork" the repository (make your own copy). It's easy --- just click the big green button on the next page. This step is only needed the first time you make a contribution. -![fork](/attachment/wiki/doc-edit/05-fork.png) +[![fork](/attachment/wiki/doc-edit/05-fork.png)](/attachment/wiki/doc-edit/05-fork.png) Now you can make your modifications. You can also preview the changes to see how they'll be formatted by clicking the "Preview changes" tab. If you're making formatting changes, please [render the site locally] to verify that everything looks correct before submitting any changes. -![edit](/attachment/wiki/doc-edit/06-edit.png) +[![edit](/attachment/wiki/doc-edit/06-edit.png)](/attachment/wiki/doc-edit/06-edit.png) Once you're finished, describe your changes at the bottom and click "Propose file change". -![commit](/attachment/wiki/doc-edit/07-commit-msg.png) +[![commit](/attachment/wiki/doc-edit/07-commit-msg.png)](/attachment/wiki/doc-edit/07-commit-msg.png) After that, you'll see exactly what modifications you've made. At this stage, those changes are still in your own copy of the documentation ("fork"). If everything looks good, send those changes to us by pressing the "Create pull request" button. -![pull-request](/attachment/wiki/doc-edit/08-review-changes.png) +[![pull-request](/attachment/wiki/doc-edit/08-review-changes.png)](/attachment/wiki/doc-edit/08-review-changes.png) You will be able to adjust the pull request message and title there. In most cases, the defaults are ok, so you can just confirm by pressing the "Create pull request" button again. -![pull-request-confirm](/attachment/wiki/doc-edit/09-create-pull-request.png) +[![pull-request-confirm](/attachment/wiki/doc-edit/09-create-pull-request.png)](/attachment/wiki/doc-edit/09-create-pull-request.png) That's all! We will review your changes. @@ -111,15 +111,16 @@ Otherwise, we may have some questions for you, which we'll post in a comment on (GitHub will automatically notify you if we do.) If, for some reason, we can't accept your pull request, we'll post a comment explaining why we can't. -![done](/attachment/wiki/doc-edit/10-done.png) +[![done](/attachment/wiki/doc-edit/10-done.png)](/attachment/wiki/doc-edit/10-done.png) ### How to add images -To add an image to a page, use the following syntax in the main document: +To add an image to a page, use the following syntax in the main document. +This will make the image a hyperlink to the image file, allowing the reader to click on the image in order to view the image by itself. ``` -![Image Title](/attachment/wiki/page-title/image-filename.png) +[![Image Title](/attachment/wiki/page-title/image-filename.png)](/attachment/wiki/page-title/image-filename.png) ``` Then, submit your image(s) in a separate pull request to the [qubes-attachment] repository using the same path and filename.