From 37cbb17fd396d36bb8e5b6b16ddf5af3d5779402 Mon Sep 17 00:00:00 2001
From: Jay McCarthy <jay.mccarthy@gmail.com>
Date: Wed, 12 Jul 2017 10:03:47 -0600
Subject: [PATCH] fixes from connors code

---
 src/site.rkt    | 15 +++++++++------
 static/todos.js |  3 +++
 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/site.rkt b/src/site.rkt
index 1b38693..feef4a0 100644
--- a/src/site.rkt
+++ b/src/site.rkt
@@ -596,7 +596,7 @@
   (define-values (pkg-rows num-todos)
     (build-pkg-rows/num-todos package-names))
   `(table
-    ((class "packages sortable") (data-todokey ,num-todos))
+    ((class "packages sortable") (data-todokey ,(number->string num-todos)))
     (thead
      (tr
       (th 'nbsp)
@@ -631,7 +631,7 @@
               [else 0]))
       (define row-xexp
         `(tr
-          ((data-todokey ,todokey))
+          ((data-todokey ,(number->string todokey)))
           (td (span ((class "last-updated-negated") (style "display: none"))
                     ,(~a (- (package-last-updated pkg))))
               ,@(maybe-splice
@@ -655,8 +655,9 @@
                    (span ((class "doctags-label")) "Tags: ")
                    ,(tag-links (package-tags pkg)))))
           ,(build-status-td pkg)
-          (td ((style "display: none")) ,todokey)))
-      (values (cons row-xexp pkg-rows) (if (> 0 todokey) (add1 num-todos) num-todos))))
+          (td ((style "display: none")) ,(number->string todokey))))
+      (values (cons row-xexp pkg-rows)
+              (+ num-todos (min todokey 1)))))
   ;; for/fold reverses pkg-rows, so un-reverse before returning.
   (values (reverse pkg-rows) num-todos))
 
@@ -728,7 +729,7 @@
                 ,(format "~a packages" (length package-name-list))
                 " "
                 (a ((href ,(format "~a?q=%20" (named-url search-page)))) "(see all, including packages tagged as \"deprecated\", \"main-distribution\", or \"main-test\")"))
-             (p ((class "package-count") (id "todo-msg")) "") ;; filled in by client-side JS.
+             (p ((class "package-count") (id "todo-msg")) "")
              ,(package-summary-table package-name-list))
            `(div ((class "jumbotron"))
                  (p "Questions? Comments? Bugs? Email "
@@ -1404,7 +1405,8 @@
 
 (define (search-page request)
   (parameterize ((bootstrap-active-navigation nav-search)
-                 (bootstrap-page-scripts (list (static-resource-url "/searchbox.js"))))
+                 (bootstrap-page-scripts (list (static-resource-url "/searchbox.js")
+                                               (static-resource-url "/todos.js"))))
     (authentication-wrap
      #:request request
      (define-form-bindings request ([search-text q ""]
@@ -1433,6 +1435,7 @@
                                      `(div
                                        (p ((class "package-count"))
                                           ,(format "~a packages found" (length package-name-list)))
+                                       (p ((class "package-count") (id "todo-msg")) "")
                                        ,(package-summary-table package-name-list))))))))))
 
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
diff --git a/static/todos.js b/static/todos.js
index 8848491..eb1648b 100644
--- a/static/todos.js
+++ b/static/todos.js
@@ -24,6 +24,7 @@ $(function() {
   var todoTotal = $("table.packages").data("todokey");
 
   if (todoTotal > 0) {
+    $("#todo-msg").show();
     $("#todo-msg").html(
       todoTotal + " todos. " +
       "<a style='cursor:pointer' id='filter-pkgs'> Click here to see them.</a>"
@@ -43,6 +44,8 @@ $(function() {
         filterIsApplied = false;
       }
     });
+  } else {
+    $("#todo-msg").hide();
   }
 
 }); /* document.ready */