From 904df22210a6cc2f060a80ebfa4a712bc5b66029 Mon Sep 17 00:00:00 2001
From: Tony Garnock-Jones <tonygarnockjones@gmail.com>
Date: Wed, 21 Dec 2016 11:32:36 +1300
Subject: [PATCH] Superusers

---
 src/sessions.rkt |  7 ++++---
 src/site.rkt     | 32 +++++++++++++++++++++-----------
 2 files changed, 25 insertions(+), 14 deletions(-)

diff --git a/src/sessions.rkt b/src/sessions.rkt
index 7f074ce..f928124 100644
--- a/src/sessions.rkt
+++ b/src/sessions.rkt
@@ -20,7 +20,7 @@
          (* 7 24 60 60)) ;; one week in seconds
      1000)) ;; convert to milliseconds
 
-(struct session (key expiry email password curator?) #:prefab)
+(struct session (key expiry email password curator? superuser?) #:prefab)
 
 (define sessions (make-persistent-state 'session-store (lambda () (make-hash))))
 
@@ -36,7 +36,7 @@
     (when (and s (<= (session-expiry s) now))
       (hash-remove! ss session-key))))
 
-(define (create-session! email password #:curator? [curator? #f])
+(define (create-session! email password #:curator? [curator? #f] #:superuser? [superuser? #f])
   (expire-sessions!)
   (define session-key (bytes->string/utf-8 (random-bytes/base64 32)))
   (hash-set! (sessions)
@@ -45,7 +45,8 @@
                       (+ (current-inexact-milliseconds) session-lifetime)
                       email
                       password
-                      curator?))
+                      curator?
+                      superuser?))
   session-key)
 
 (define (destroy-session! session-key)
diff --git a/src/site.rkt b/src/site.rkt
index ac76545..09a8463 100644
--- a/src/site.rkt
+++ b/src/site.rkt
@@ -357,10 +357,16 @@
                           'passwd password
                           'code code)))
 
-(define (authentication-success->curator? success)
-  (match success
-    [#t #f] ;; new user -- we can only assume they are *not* curators
-    [(hash-table ('curation curator?) _ ...) (if curator? #t #f)]))
+(define (create-session-from-authentication-success! email password success)
+  ;; An "authentication success" is either #t, signalling a new user,
+  ;; or a hash-table with interesting facts in it.
+  (define user-facts (cond [(eq? success #t) (hasheq)]
+                           [(hash? success) success]
+                           [else (log-warning "Bad auth success for user ~v: ~v" email success)
+                                 (hasheq)]))
+  (create-session! email password
+                   #:curator? (if (hash-ref user-facts 'curation #f) #t #f)
+                   #:superuser? (if (hash-ref user-facts 'superuser #f) #t #f)))
 
 (define (process-login-credentials request)
   (define-form-bindings request (email password))
@@ -373,8 +379,7 @@
         [(or "emailed" #f)
          (summarise-code-emailing "Incorrect password, or nonexistent user." email)]
         [success
-         (create-session! email password
-                          #:curator? (authentication-success->curator? success))])))
+         (create-session-from-authentication-success! email password success)])))
 
 (define (register-form #:email [email ""]
                        #:code [code ""]
@@ -452,8 +457,7 @@
       [success
        ;; The email and password combo we have been given is good to go.
        ;; Set a cookie and consider ourselves logged in.
-       (create-session! email password
-                        #:curator? (authentication-success->curator? success))])]))
+       (create-session-from-authentication-success! email password success)])]))
 
 (define (notify-of-emailing request)
   (define-form-bindings request (email_for_code))
@@ -742,6 +746,11 @@
                        `(ul (li (a ((href ,(main-page-url)))
                                    "Return to the package index"))))))
 
+(define (current-user-may-edit? pkg)
+  (or (member (current-email) (package-authors pkg))
+      (and (current-session)
+           (session-superuser? (current-session)))))
+
 (define (package-page request package-name-str)
   (define package-name (string->symbol package-name-str))
   (define pkg (package-detail package-name))
@@ -827,7 +836,7 @@
                               ,(glyphicon 'link) " Code"))
 
                      ,@(maybe-splice
-                        (member (current-email) (package-authors pkg))
+                        (current-user-may-edit? pkg)
                         " "
                         `(a ((class "btn btn-info btn-lg")
                              (href ,(named-url edit-package-page package-name-str)))
@@ -952,8 +961,8 @@
    (define package-name (string->symbol package-name-str))
    (define pkg (package-detail package-name))
    (cond
-    [(and pkg (not (member (current-email) (package-authors pkg))))
-     ;; Not ours. Show it instead.
+    [(and pkg (not (current-user-may-edit? pkg)))
+     ;; Exists, isn't ours, and we're not superuser. Show it instead.
      (bootstrap-redirect (view-package-url package-name))]
     [(not pkg)
      ;; Doesn't exist.
@@ -964,6 +973,7 @@
                                      '()
                                      `(("default" ,default-empty-parsed-package-source))))]
     [else
+     ;; Exists, and either ours or we are superuser.
      (package-form #f
                    (draft-package package-name-str
                                   package-name-str