suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

optimizer: don't mark (-) as omittable

Browse Source 
The application of some procedures are omittables when the arguments have
certain properties. Check the arity of the procedure before marking the application as omittable.
The only case that appears to be relevant is the expression (-).
This commit is contained in:
Gustavo Massaccesi 2016-07-18 17:43:40 -03:00
parent 8bb79deaa2
commit 004fd02501
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkgs/racket-test-core/tests/racket/optimize.rktl
View File

@ -4339,6 +4339,13 @@
(check-number-op-unary 'sub1) (check-number-op-unary 'sub1)
(check-number-op-unary 'abs)) (check-number-op-unary 'abs))
(test-comp '(lambda () (-) (void))
'(lambda () (void))
#f)
(test-comp '(lambda () (/) (void))
'(lambda () (void))
#f)
;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Check elimination of dead code after error ;; Check elimination of dead code after error
(test-comp '(lambda () (random) (error 'error)) (test-comp '(lambda () (random) (error 'error))

4
racket/src/racket/src/optimize.c
View File

@ -3431,7 +3431,9 @@ static Scheme_Object *finish_optimize_application(Scheme_App_Rec *app, Optimize_
info->single_result = -info->single_result; info->single_result = -info->single_result;
} }
if (SCHEME_PRIMP(app->args[0])) { if (SCHEME_PRIMP(app->args[0])
&& (app->num_args >= ((Scheme_Primitive_Proc *)app->args[0])->mina)
&& (app->num_args <= ((Scheme_Primitive_Proc *)app->args[0])->mu.maxa)) {
Scheme_Object *app_o = (Scheme_Object *)app, *rator = app->args[0]; Scheme_Object *app_o = (Scheme_Object *)app, *rator = app->args[0];
Scheme_Object *rand1 = NULL, *rand2 = NULL; Scheme_Object *rand1 = NULL, *rand2 = NULL;