suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pick better names for new module-expansion properties

Browse Source 
In retrospect, 'module-body-outside-context wasn't a good
name for a property that turned out to hold only an
inside-edge scope.
This commit is contained in:
Matthew Flatt 2016-01-13 07:53:50 -07:00
parent 6ea9e963c4
commit 052c7e4c06
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkgs/racket-doc/scribblings/reference/stx-expand.scrbl
View File

@ -146,7 +146,7 @@ to the syntax object:
be exported indirectly through macro expansions. Definitions of be exported indirectly through macro expansions. Definitions of
macro-generated identifiers create uninterned symbols in this list.} macro-generated identifiers create uninterned symbols in this list.}
@item{@indexed-racket['module-body-inside-context] --- a syntax @item{@indexed-racket['module-body-context] --- a syntax
object whose @tech{lexical information} corresponds to the inside of object whose @tech{lexical information} corresponds to the inside of
the module, so it includes the expansion's @tech{outside-edge scope} the module, so it includes the expansion's @tech{outside-edge scope}
and its @tech{inside-edge scope}; that is, the syntax object and its @tech{inside-edge scope}; that is, the syntax object
@ -157,7 +157,7 @@ to the syntax object:
@history[#:added "6.4.0.1"]} @history[#:added "6.4.0.1"]}
@item{@indexed-racket['module-body-outside-context] --- a syntax @item{@indexed-racket['module-body-inside-context] --- a syntax
object whose @tech{lexical information} corresponds to an identifier object whose @tech{lexical information} corresponds to an identifier
that starts with no lexical context and is moved into the macro, so that starts with no lexical context and is moved into the macro, so
that it includes only the expansions's @tech{inside-edge scope}. that it includes only the expansions's @tech{inside-edge scope}.

4
pkgs/racket-test-core/tests/racket/module.rktl
View File

@ -1731,8 +1731,8 @@ case of module-leve bindings; it doesn't cover local bindings.
(test (not with-kar?) syntax-property m 'module-body-context-simple?) (test (not with-kar?) syntax-property m 'module-body-context-simple?)
(define i (syntax-property m 'module-body-inside-context)) (define i (syntax-property m 'module-body-context))
(define o (syntax-property m 'module-body-outside-context)) (define o (syntax-property m 'module-body-inside-context))
(test #t syntax? i) (test #t syntax? i)
(test #t syntax? o) (test #t syntax? o)

4
racket/src/racket/src/module.c
View File

@ -7497,13 +7497,13 @@ static Scheme_Object *do_module(Scheme_Object *form, Scheme_Comp_Env *env,
stx = scheme_datum_to_syntax(scheme_intern_symbol("inside"), scheme_false, scheme_false, 0, 0); stx = scheme_datum_to_syntax(scheme_intern_symbol("inside"), scheme_false, scheme_false, 0, 0);
stx = scheme_stx_add_module_context(stx, rn_set); stx = scheme_stx_add_module_context(stx, rn_set);
fm = scheme_stx_property(fm, fm = scheme_stx_property(fm,
scheme_intern_symbol("module-body-inside-context"), scheme_intern_symbol("module-body-context"),
scheme_stx_add_shift(stx, ps)); scheme_stx_add_shift(stx, ps));
stx = scheme_datum_to_syntax(scheme_intern_symbol("outside"), scheme_false, scheme_false, 0, 0); stx = scheme_datum_to_syntax(scheme_intern_symbol("outside"), scheme_false, scheme_false, 0, 0);
stx = scheme_stx_introduce_to_module_context(stx, rn_set); stx = scheme_stx_introduce_to_module_context(stx, rn_set);
fm = scheme_stx_property(fm, fm = scheme_stx_property(fm,
scheme_intern_symbol("module-body-outside-context"), scheme_intern_symbol("module-body-inside-context"),
scheme_stx_add_shift(stx, ps)); scheme_stx_add_shift(stx, ps));
} }