From 05fced3a68dc1adaf78dbee554ce1a988331777c Mon Sep 17 00:00:00 2001 From: Asumu Takikawa Date: Mon, 4 Nov 2013 20:10:17 -0500 Subject: [PATCH] Be more picky about Opaque type parsing Closes PR 14122 --- .../typed-racket-lib/typed-racket/private/parse-type.rkt | 2 +- .../tests/typed-racket/unit-tests/parse-type-tests.rkt | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/private/parse-type.rkt b/pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/private/parse-type.rkt index b9ba870788..79f944fc7a 100644 --- a/pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/private/parse-type.rkt +++ b/pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/private/parse-type.rkt @@ -285,7 +285,7 @@ (-val (syntax->datum #'t))] [((~and kw t:All) . rest) (parse-all-type stx)] - [((~and kw t:Opaque) p?) + [((~and kw t:Opaque) p?:id) (add-disappeared-use #'kw) (make-Opaque #'p?)] [((~and kw t:Parameter) t) diff --git a/pkgs/typed-racket-pkgs/typed-racket-test/tests/typed-racket/unit-tests/parse-type-tests.rkt b/pkgs/typed-racket-pkgs/typed-racket-test/tests/typed-racket/unit-tests/parse-type-tests.rkt index 350d780549..fc0f601a36 100644 --- a/pkgs/typed-racket-pkgs/typed-racket-test/tests/typed-racket/unit-tests/parse-type-tests.rkt +++ b/pkgs/typed-racket-pkgs/typed-racket-test/tests/typed-racket/unit-tests/parse-type-tests.rkt @@ -137,6 +137,9 @@ [(Integer -> (All (X) (X -> X))) (t:-> -Integer (-poly (x) (t:-> x x)))] + [(Opaque foo?) (make-Opaque #'foo?)] + ;; PR 14122 + [FAIL (Opaque 3)] )) ;; FIXME - add tests for parse-values-type, parse-tc-results