suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

search page: avoid propagating "q" query

Browse Source 
When you search in a page other than the main search page, the search
request is communicated as a "q" query in the URL. Meanwhile, the search
page generally propagates all query arguments, as a kind of store-passing
facility, which means that the "q" query was passed along. Avoid adding the
"q" to search results, so it doesn't get propagated so much.

Closes #936
This commit is contained in:
Matthew Flatt 2021-04-27 16:13:40 -06:00
parent 613e142447
commit 09b61f06c1
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pkgs/racket-index/scribblings/main/private/search.js
View File

@ -679,11 +679,23 @@ function UncompactHtml(x) {
}
}
function StripQArg(args) {
// Don't propagate the `q=...` argument that is used to communicate
// to this search page
if (!args)
return false;
args = args.replace(/^[?]q=[^&]*&/,"?").replace(/^[?]q=[^&]*$/,"?").replace(/&q=[^&]*/,"");
if (args == "?")
return false;
else
return args;
}
function UpdateResults() {
if (first_search_result < 0 ||
first_search_result >= search_results.length)
first_search_result = 0;
var link_args = (page_query_string && ("?"+page_query_string));
var link_args = page_query_string && StripQArg("?"+page_query_string);
for (var i=0; i<result_links.length; i++) {
var n = i + first_search_result;
if (n < search_results.length) {