suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve error message when an unknown dependent variable is used

Browse Source
This commit is contained in:
Robby Findler 2015-11-07 19:10:32 -06:00
parent 657cda6e12
commit 12d063ad87
1 changed files with 37 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
racket/collects/racket/contract/private/arr-i-parse.rkt
View File

@ -5,7 +5,8 @@
;; has these old, wrong names in it.
[make-module-identifier-mapping make-free-identifier-mapping]
[module-identifier-mapping-get free-identifier-mapping-get]
[module-identifier-mapping-put! free-identifier-mapping-put!])
[module-identifier-mapping-put! free-identifier-mapping-put!]
[module-identifier-mapping-for-each free-identifier-mapping-for-each])
"application-arity-checking.rkt"
"arr-util.rkt"
(for-template racket/base
@ -100,8 +101,41 @@ code does the parsing and validation of the syntax.
(define (ensure-bound vars)
(for ([var (in-list vars)])
(unless (free-identifier-mapping-get nm var (λ () #f))
(raise-syntax-error #f "dependent variable not bound"
stx var))))
(define vars '())
(free-identifier-mapping-for-each
nm
(λ (id _)
(define sym (syntax-e id))
(unless (member sym vars)
(set! vars (cons sym vars)))))
(define (insert x l)
(cond
[(null? l) (list x)]
[else
(cond
[(symbol<? x (car l))
(cons x l)]
[else
(cons (car l) (insert x (cdr l)))])]))
(define sorted-vars
(let loop ([vars vars])
(cond
[(null? vars) '()]
[else (insert (car vars) (loop (cdr vars)))])))
(raise-syntax-error
#f
(apply
string-append
"unknown dependent variable;"
"\n not the variable used in any of the components of the ->i expression"
"\n variables:"
(for/list ([var (in-list sorted-vars)]
[i (in-naturals)])
(format " ~a" var)))
stx var))))
;; not-range-bound : (listof identifier[used-by-an-arg]) -> void
(define (not-range-bound arg-vars arg?)