suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix bug introduced in f315f08dc3

Browse Source 
closes PR 13435

Also cleaned up one more threading problem (this one was
probably innocuous, but it is hard to be sure and the
rewrite is easier to see that it isn't problematic)
This commit is contained in:
Robby Findler 2013-01-15 14:45:42 -06:00
parent 28d46105c9
commit 131af9955d
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
collects/help/bug-report.rkt
View File

@ -201,6 +201,7 @@
(set! cancel-kill-cust (make-custodian)) (set! cancel-kill-cust (make-custodian))
(define response-chan (make-channel)) (define response-chan (make-channel))
(define exn-chan (make-channel)) (define exn-chan (make-channel))
(define starter-query (get-query))
(define worker-thread (define worker-thread
(parameterize ([current-custodian cancel-kill-cust] (parameterize ([current-custodian cancel-kill-cust]
[current-alist-separator-mode 'amp]) [current-alist-separator-mode 'amp])
@ -222,16 +223,15 @@
"Are you human?" ; FIXME: use string-constant "Are you human?" ; FIXME: use string-constant
captcha-question bug-frame))) captcha-question bug-frame)))
(define post-data (define post-data
(let* ([q (get-query)] (let* ([q (if captcha-answer
[q (if captcha-answer
`([captcha . ,captcha-answer] `([captcha . ,captcha-answer]
;; send back the question too: if things get really ;; send back the question too: if things get really
;; bad, then the server can make up random captchas ;; bad, then the server can make up random captchas
;; and check the reply against the challenge that ;; and check the reply against the challenge that
;; was used ;; was used
[captcha-question . ,captcha-question] [captcha-question . ,captcha-question]
,@q) ,@starter-query)
q)]) starter-query)])
(string->bytes/utf-8 (alist->form-urlencoded q)))) (string->bytes/utf-8 (alist->form-urlencoded q))))
(call/input-url (call/input-url

2
collects/help/private/bug-report-controls.rkt
View File

@ -322,7 +322,7 @@
(format "Human Language: ~a\n" (send human-language get-value)) (format "Human Language: ~a\n" (send human-language get-value))
(format "(current-memory-use) ~a\n" (send memory-use get-value)) (format "(current-memory-use) ~a\n" (send memory-use get-value))
(format "Links: ~a\n" (send links-ctrl get-value)) (format "Links: ~a\n" (send links-ctrl get-value))
(format "Planet2 (show):\n~a\n" (send planet2-info get-value)) (format "Planet2 (show):\n~a\n" (send (send planet2-info get-editor) get-text))
"\n" "\n"
"\nCollections:\n" "\nCollections:\n"
(format "~a" (send (send collections get-editor) get-text)) (format "~a" (send (send collections get-editor) get-text))