suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Have TR log regexp operations that use non-regexp patterns.

Browse Source 
For consumption by Optimization Coach.
This commit is contained in:
Vincent St-Amour 2014-06-29 14:14:32 -04:00
parent 05760a12f6
commit 13f1565f4d
2 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/optimizer/hidden-costs.rkt
View File

@ -13,6 +13,12 @@
(display displayln newline write write-byte write-bytes print printf))
(define-literal-syntax-class hidden-random-parameter-function
(random))
(define-literal-syntax-class regexp-function
(regexp-match regexp-try-match regexp-match-positions regexp-match?
regexp-match-peek regexp-match-peek-positions regexp-match-peek-immediate
regexp-match-peek-positions-immediate regexp-match-peek-positions
regexp-match/end regexp-match-positions/end regexp-match-peek-positions/end
regexp-match-peek-positions-immediate/end regexp-split))
;; This syntax class does not perform optimization.
;; It only logs operations with hidden costs, for use by Optimization Coach.
@ -49,4 +55,13 @@
(or (and constructor-for (struct-constructor? constructor-for))
(struct-constructor? #'op)))
#:do [(log-optimization-info "struct constructor" #'op)]
#:with opt (syntax/loc this-syntax (op-part args.opt ...))))
#:with opt (syntax/loc this-syntax (op-part args.opt ...)))
;; regexp-match (or other regexp operation) with non-regexp pattern argument
;; (i.e. string or bytes)
(pattern (#%plain-app op:regexp-function pattern-arg:opt-expr
args:opt-expr ...)
#:when (not (or (subtypeof? #'pattern-arg -Regexp)
(subtypeof? #'pattern-arg -Byte-Regexp)))
#:do [(log-optimization-info "non-regexp pattern" #'pattern-arg)]
#:with opt (syntax/loc this-syntax (op pattern-arg.opt args.opt ...))))

19
pkgs/typed-racket-pkgs/typed-racket-test/tests/typed-racket/optimizer/missed-optimizations/regexp.rkt Normal file
View File

@ -0,0 +1,19 @@
#;#;
#<<END
TR info: regexp.rkt 2:14 "foo" -- non-regexp pattern
TR info: regexp.rkt 3:14 #"foo" -- non-regexp pattern
END
#<<END
'("foo")
'(#"foo")
'("foo")
'(#"foo")
END
#lang typed/racket
#reader tests/typed-racket/optimizer/reset-port
(regexp-match "foo" "foo")
(regexp-match #"foo" #"foo")
(regexp-match (regexp "foo") "foo") ; ok
(regexp-match (byte-regexp #"foo") #"foo") ; ok