From 1975014c550011f3937ed7bb3ce511c1a5a823a9 Mon Sep 17 00:00:00 2001 From: Vincent St-Amour Date: Tue, 11 Sep 2012 11:42:31 -0400 Subject: [PATCH] Remove TR optimizer log key, made redundant by named loggers. --- collects/typed-racket/optimizer/logging.rkt | 16 +--------------- collects/typed-racket/optimizer/tool/logging.rkt | 2 +- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/collects/typed-racket/optimizer/logging.rkt b/collects/typed-racket/optimizer/logging.rkt index 3fd4eaf2d4..483f78bf58 100644 --- a/collects/typed-racket/optimizer/logging.rkt +++ b/collects/typed-racket/optimizer/logging.rkt @@ -5,7 +5,6 @@ "../utils/tc-utils.rkt") (provide log-optimization log-missed-optimization - log-message-from-tr-opt? with-tr-logging-to-port (struct-out log-entry) (struct-out opt-log-entry) @@ -17,20 +16,12 @@ (define TR-logger (make-logger 'TR-optimizer (current-logger))) (define (emit-log-message l) - (log-message TR-logger TR-logging-level - (format-log-entry l) - (cons optimization-log-key l))) + (log-message TR-logger TR-logging-level (format-log-entry l) l)) ;; producing logs can be expensive, don't do it if no-one's listening ;; to the logs (define (anyone-listening?) (log-level? TR-logger TR-logging-level)) -;; to identify log messages that come from the optimizer -;; to be stored in the data section of log messages -;; external tools/scripts (like the test harness) can look for it -;; since this is used across phases, can't be a gensym -(define optimization-log-key 'log-message-coming-from-the-TR-optimizer) - ;; msg is for consumption by the DrRacket tool (struct log-entry (kind msg stx located-stx pos provenance) #:prefab) ;; for optimizations only (not missed optimizations, those are below) @@ -123,11 +114,6 @@ ;;-------------------------------------------------------------------- -(define (log-message-from-tr-opt? l) - (let ([data (vector-ref l 2)]) - (and (pair? data) - (eq? (car data) optimization-log-key)))) - (define (with-tr-logging-to-port port thunk) (with-intercepted-logging (lambda (l) diff --git a/collects/typed-racket/optimizer/tool/logging.rkt b/collects/typed-racket/optimizer/tool/logging.rkt index f0c4a00969..5158877411 100644 --- a/collects/typed-racket/optimizer/tool/logging.rkt +++ b/collects/typed-racket/optimizer/tool/logging.rkt @@ -15,7 +15,7 @@ (with-intercepted-logging (lambda (l) ;; From TR, use the log-entry struct provided. - (interceptor (cdr (vector-ref l 2)))) + (interceptor (vector-ref l 2))) thunk 'debug 'TR-optimizer)) 'debug 'optimizer))