suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix optimizer bug

Browse Source 
Closes #1461

Thanks to Gustavo for tracking down the problem.
This commit is contained in:
Matthew Flatt 2016-09-15 07:58:21 -06:00
parent cfb2a7aa32
commit 2174f4a029
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkgs/racket-test-core/tests/racket/optimize.rktl
View File

@ -6230,6 +6230,16 @@
(eval (read (open-input-bytes (get-output-bytes o))))) (eval (read (open-input-bytes (get-output-bytes o)))))
((dynamic-require ''uses-mutator-with-an-auto-field 'f) #f)) ((dynamic-require ''uses-mutator-with-an-auto-field 'f) #f))
;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Make sure that the optimizer doesn't discard a known error on the
;; right-hand side of a `letrec`
(err/rt-test
(letrec-values ([() (list (3) the-val)]
[(the-val) 42])
777)
exn:fail:contract?)
;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
(report-errs) (report-errs)

2
racket/src/racket/src/optimize.c
View File

@ -7136,7 +7136,7 @@ static Scheme_Object *optimize_lets(Scheme_Object *form, Optimize_Info *info, in
(values (if id e1 e2) ...) and then split the values call, since (values (if id e1 e2) ...) and then split the values call, since
duplicating the id use and test is likely to pay off. */ duplicating the id use and test is likely to pay off. */
if ((pre_body->count != 1) if ((pre_body->count != 1)
&& (found_escapes && ((!is_rec && found_escapes)
|| (is_values_apply(value, pre_body->count, rhs_info, merge_skip_vars, 1) || (is_values_apply(value, pre_body->count, rhs_info, merge_skip_vars, 1)
&& ((!is_rec && no_mutable_bindings(pre_body)) && ((!is_rec && no_mutable_bindings(pre_body))
/* If the right-hand side is omittable, then there are /* If the right-hand side is omittable, then there are