audit framework begin-edit-sequence calls

This commit is contained in:
Robby Findler 2013-09-14 19:08:12 -05:00
parent 28e2d6098b
commit 2b30be3265
4 changed files with 19 additions and 19 deletions

View File

@ -1035,7 +1035,7 @@ added get-regions
;; See docs ;; See docs
;; smart-skip : (or/c #f 'adjacent 'forward) ;; smart-skip : (or/c #f 'adjacent 'forward)
(define/public (insert-close-paren pos char flash? fixup? [smart-skip #f]) (define/public (insert-close-paren pos char flash? fixup? [smart-skip #f])
(begin-edit-sequence) (begin-edit-sequence #t #f)
(define closers (map symbol->string (map cadr pairs))) (define closers (map symbol->string (map cadr pairs)))
(define closer (get-close-paren pos (define closer (get-close-paren pos
(if fixup? ;; Ensure preference for given character: (if fixup? ;; Ensure preference for given character:

View File

@ -2099,7 +2099,7 @@
(define start-pos (min first-pos last-pos)) (define start-pos (min first-pos last-pos))
(define end-pos (max first-pos last-pos)) (define end-pos (max first-pos last-pos))
(send text begin-edit-sequence) (send text begin-edit-sequence #t #f)
(send text set-caret-owner #f 'display) (send text set-caret-owner #f 'display)
(send text set-position start-pos end-pos #f #f 'local) (send text set-position start-pos end-pos #f #f 'local)
@ -2435,7 +2435,7 @@
(unless (memq search/replace-panel (send super-root get-children)) (unless (memq search/replace-panel (send super-root get-children))
(send super-root add-child search/replace-panel)) (send super-root add-child search/replace-panel))
(search-parameters-changed) (search-parameters-changed)
(send find-edit begin-edit-sequence) (send find-edit begin-edit-sequence #t #f)
(when new-search-string-from-selection? (when new-search-string-from-selection?
(update-search-string-from-selection)) (update-search-string-from-selection))
(when focus? (when focus?
@ -2449,7 +2449,7 @@
(let ([canvas (and text-to-search (send text-to-search get-canvas))]) (let ([canvas (and text-to-search (send text-to-search get-canvas))])
(cond (cond
[(or (not text-to-search) (and canvas (send canvas has-focus?))) [(or (not text-to-search) (and canvas (send canvas has-focus?)))
(send find-edit begin-edit-sequence) (send find-edit begin-edit-sequence #t #f)
(when new-search-string-from-selection? (when new-search-string-from-selection?
(update-search-string-from-selection)) (update-search-string-from-selection))
(send find-edit set-position 0 (send find-edit last-position)) (send find-edit set-position 0 (send find-edit last-position))

View File

@ -767,7 +767,7 @@
(define (insert-return) (define (insert-return)
(if (tabify-on-return?) (if (tabify-on-return?)
(begin (begin
(begin-edit-sequence) (begin-edit-sequence #t #f)
(insert #\newline) (insert #\newline)
(tabify (get-start-position)) (tabify (get-start-position))
(set-position (set-position
@ -1076,7 +1076,7 @@
[closer (and paren? [closer (and paren?
(get-forward-sexp pos))]) (get-forward-sexp pos))])
(if (and paren? closer) (if (and paren? closer)
(begin (begin-edit-sequence) (begin (begin-edit-sequence #t #f)
(delete pos (add1 pos)) (delete pos (add1 pos))
(delete (- closer 2) (- closer 1)) (delete (- closer 2) (- closer 1))
(end-edit-sequence)) (end-edit-sequence))
@ -1131,7 +1131,7 @@
(end-edit-sequence)))) (end-edit-sequence))))
(define/public (move-sexp-out begin-inner) (define/public (move-sexp-out begin-inner)
(begin-edit-sequence) (begin-edit-sequence #t #f)
(let ([end-inner (get-forward-sexp begin-inner)] (let ([end-inner (get-forward-sexp begin-inner)]
[begin-outer (find-up-sexp begin-inner)]) [begin-outer (find-up-sexp begin-inner)])
(cond (cond
@ -1147,7 +1147,7 @@
(end-edit-sequence)) (end-edit-sequence))
(define/public (kill-enclosing-parens begin-inner) (define/public (kill-enclosing-parens begin-inner)
(begin-edit-sequence) (begin-edit-sequence #t #f)
(define begin-outer (find-up-sexp begin-inner)) (define begin-outer (find-up-sexp begin-inner))
(cond (cond
[begin-outer [begin-outer
@ -1163,7 +1163,7 @@
;; change the parens following the cursor from () to [] or vice versa ;; change the parens following the cursor from () to [] or vice versa
(define/public (toggle-round-square-parens start-pos) (define/public (toggle-round-square-parens start-pos)
(begin-edit-sequence) (begin-edit-sequence #t #f)
(let* ([sexp-begin (skip-whitespace start-pos 'forward #f)] (let* ([sexp-begin (skip-whitespace start-pos 'forward #f)]
[sexp-end (get-forward-sexp sexp-begin)]) [sexp-end (get-forward-sexp sexp-begin)])
(cond [(and sexp-end (cond [(and sexp-end
@ -1562,7 +1562,7 @@
(define selection-start (send text get-start-position)) (define selection-start (send text get-start-position))
(define selection-end (send text get-end-position)) (define selection-end (send text get-end-position))
(define open-len (if (string? open-brace) (string-length open-brace) 1)) (define open-len (if (string? open-brace) (string-length open-brace) 1))
(send text begin-edit-sequence) (send text begin-edit-sequence #t #f)
(send text insert open-brace selection-start) (send text insert open-brace selection-start)
(define tok-type (send text classify-position selection-start)) (define tok-type (send text classify-position selection-start))
(when (or (not checkp) (when (or (not checkp)

View File

@ -576,7 +576,7 @@
(define/public (get-edition-number) edition) (define/public (get-edition-number) edition)
(define/augment (on-insert start len) (define/augment (on-insert start len)
(begin-edit-sequence) (begin-edit-sequence #t #f)
(inner (void) on-insert start len)) (inner (void) on-insert start len))
(define/augment (after-insert start len) (define/augment (after-insert start len)
(set! edition (+ edition 1)) (set! edition (+ edition 1))
@ -871,7 +871,7 @@
(inherit begin-edit-sequence end-edit-sequence delete insert get-character) (inherit begin-edit-sequence end-edit-sequence delete insert get-character)
(define/augment (on-insert start len) (define/augment (on-insert start len)
(inner (void) on-insert start len) (inner (void) on-insert start len)
(begin-edit-sequence)) (begin-edit-sequence #t #f))
(inherit find-string) (inherit find-string)
(define/augment (after-insert start len) (define/augment (after-insert start len)
(unless rewriting (unless rewriting
@ -922,7 +922,7 @@
'end))) 'end)))
(define old-char-w char-width) (define old-char-w char-width)
(set! char-width new-cw) (set! char-width new-cw)
(begin-edit-sequence) (begin-edit-sequence #t #f)
(inv old-char-w) (inv old-char-w)
(inv char-width) (inv char-width)
(end-edit-sequence))) (end-edit-sequence)))
@ -1149,7 +1149,7 @@
(define/public (get-anchor-pos) anchor-pos) (define/public (get-anchor-pos) anchor-pos)
(define/public (set-search-anchor position) (define/public (set-search-anchor position)
(begin-edit-sequence) (begin-edit-sequence #t #f)
(when anchor-pos (unhighlight-anchor)) (when anchor-pos (unhighlight-anchor))
(cond (cond
[(and position [(and position
@ -1229,7 +1229,7 @@
(unhighlight-replace))] (unhighlight-replace))]
[else [else
(define next (do-search (get-start-position) 'eof)) (define next (do-search (get-start-position) 'eof))
(begin-edit-sequence) (begin-edit-sequence #t #f)
(cond (cond
[next [next
(unless (and to-replace-highlight (unless (and to-replace-highlight
@ -1286,7 +1286,7 @@
(clear-yellow) (clear-yellow)
(set! clear-yellow void)] (set! clear-yellow void)]
[else [else
(begin-edit-sequence) (begin-edit-sequence #t #f)
(clear-yellow) (clear-yellow)
(set! clear-yellow void) (set! clear-yellow void)
(when (and searching-str (= (string-length searching-str) (- end start))) (when (and searching-str (= (string-length searching-str) (- end start)))
@ -1351,7 +1351,7 @@
(end-edit-sequence)) (end-edit-sequence))
(pause) (pause)
(when was-in-edit-sequence? (when was-in-edit-sequence?
(begin-edit-sequence)) (begin-edit-sequence #t #f))
(set! did-something? #f) (set! did-something? #f)
(set! start-time (current-inexact-milliseconds)) (set! start-time (current-inexact-milliseconds))
#t] #t]
@ -1404,7 +1404,7 @@
(maybe-pause) (maybe-pause)
(begin-edit-sequence) (begin-edit-sequence #t #f)
(clear-all-regions) (clear-all-regions)
(maybe-pause) (maybe-pause)
@ -1420,7 +1420,7 @@
(update-yellow) (update-yellow)
(end-edit-sequence)] (end-edit-sequence)]
[else [else
(begin-edit-sequence) (begin-edit-sequence #t #f)
(clear-all-regions) (clear-all-regions)
(set! search-hit-count 0) (set! search-hit-count 0)
(set! before-caret-search-hit-count 0) (set! before-caret-search-hit-count 0)