suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix registration of Opaque type alias in REPL

Browse Source 
Closes PR 14487
This commit is contained in:
Asumu Takikawa 2014-05-07 10:51:13 -04:00
parent 903e82731e
commit 2bd20a652e
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/base-env/prims.rkt
View File

@ -139,7 +139,7 @@ This file defines two sorts of primitives. All of them are provided into any mod
[syntax/define (normalize-definition)] [syntax/define (normalize-definition)]
[typed-racket/private/parse-type (parse-type)] [typed-racket/private/parse-type (parse-type)]
[typed-racket/private/type-contract (type->contract type->contract-fail)] [typed-racket/private/type-contract (type->contract type->contract-fail)]
[typed-racket/env/type-name-env (register-type-name)])) [typed-racket/env/type-alias-env (register-resolved-type-alias)]))
(define-for-syntax (with-type* expr ty) (define-for-syntax (with-type* expr ty)
(with-type #`(ann #,expr #,ty))) (with-type #`(ann #,expr #,ty)))
@ -380,7 +380,11 @@ This file defines two sorts of primitives. All of them are provided into any mod
(pattern #:name-exists)) (pattern #:name-exists))
(syntax-parse stx (syntax-parse stx
[(_ ty:id pred:id lib (~optional ne:name-exists-kw) ...) [(_ ty:id pred:id lib (~optional ne:name-exists-kw) ...)
(register-type-name #'ty (make-Opaque #'pred)) ;; This line appears redundant with the use of `define-type-alias` below, but
;; it's actually necessary for top-level uses because this opaque type may appear
;; in subsequent `require/typed` clauses, which needs to parse the types at
;; expansion-time, not at typechecking time when aliases are installed.
(register-resolved-type-alias #'ty (make-Opaque #'pred))
(with-syntax ([hidden (generate-temporary #'pred)]) (with-syntax ([hidden (generate-temporary #'pred)])
(quasisyntax/loc stx (quasisyntax/loc stx
(begin (begin

7
pkgs/typed-racket-pkgs/typed-racket-test/tests/typed-racket/unit-tests/interactive-tests.rkt
View File

@ -100,6 +100,13 @@
(test-form #rx"^$" (test-form #rx"^$"
(struct foo ())) (struct foo ()))
;; PR 14487
(test-form-not-exn
(require/typed racket/base
[#:opaque Evt evt?]
[alarm-evt (Real -> Evt)]
[sync (Evt -> Any)]))
;; PR 14380 ;; PR 14380
(test-form-not-exn (begin - (void))) (test-form-not-exn (begin - (void)))