From 2be9c6b1156476ef08867a57cc3128a5282e0529 Mon Sep 17 00:00:00 2001 From: Jay McCarthy Date: Wed, 5 Nov 2008 23:19:16 +0000 Subject: [PATCH] Moving TODOs svn: r12323 --- collects/web-server/lang/lang-api.ss | 1 - collects/web-server/private/url-param.ss | 1 - collects/web-server/private/util.ss | 1 - collects/web-server/private/xexpr-extras.ss | 1 - collects/web-server/scribblings/private.scrbl | 6 ------ collects/web-server/scribblings/servlet.scrbl | 10 ---------- 6 files changed, 20 deletions(-) diff --git a/collects/web-server/lang/lang-api.ss b/collects/web-server/lang/lang-api.ss index aeaf251aee..94f6979549 100644 --- a/collects/web-server/lang/lang-api.ss +++ b/collects/web-server/lang/lang-api.ss @@ -14,7 +14,6 @@ (all-from-out "../private/request-structs.ss") (all-from-out "../private/response-structs.ss") (all-from-out "../servlet/helpers.ss") - ; XXX Try to remove, or only provide send/suspend (all-from-out "abort-resume.ss") (all-from-out "web.ss") (all-from-out "web-cells.ss") diff --git a/collects/web-server/private/url-param.ss b/collects/web-server/private/url-param.ss index 4ad2963d99..a25ca7c6b4 100644 --- a/collects/web-server/private/url-param.ss +++ b/collects/web-server/private/url-param.ss @@ -4,7 +4,6 @@ mzlib/plt-match mzlib/list "util.ss") -; XXX Use instead of embed-ids (provide/contract [extract-param (url? string? . -> . (or/c string? false/c))] [insert-param (url? string? string? . -> . url?)]) diff --git a/collects/web-server/private/util.ss b/collects/web-server/private/util.ss index 4830ac89c0..0594e71877 100644 --- a/collects/web-server/private/util.ss +++ b/collects/web-server/private/util.ss @@ -23,7 +23,6 @@ [url-path->string ((listof path/param?) . -> . string?)] [network-error ((symbol? string?) (listof any/c) . ->* . (void))] [directory-part (path? . -> . path?)] - ; XXX Eliminate use of this [lowercase-symbol! ((or/c string? bytes?) . -> . symbol?)] [exn->string ((or/c exn? any/c) . -> . string?)] [build-path-unless-absolute (path-string? path-string? . -> . path?)] diff --git a/collects/web-server/private/xexpr-extras.ss b/collects/web-server/private/xexpr-extras.ss index 51627731e8..67b0880ce9 100644 --- a/collects/web-server/private/xexpr-extras.ss +++ b/collects/web-server/private/xexpr-extras.ss @@ -1,7 +1,6 @@ #lang scheme/base (require net/url mzlib/plt-match) -; XXX contract (provide xexpr+extras->xexpr) (define xexpr+extras->xexpr diff --git a/collects/web-server/scribblings/private.scrbl b/collects/web-server/scribblings/private.scrbl index ba67d95a60..fa634b58a5 100644 --- a/collects/web-server/scribblings/private.scrbl +++ b/collects/web-server/scribblings/private.scrbl @@ -57,7 +57,6 @@ procedures after a given amount of time, that may be extended. } -@; XXX Generalize @; ------------------------------------------------------------ @section[#:tag "connection-manager.ss"]{Connection Manager} @(require (for-label web-server/private/connection-manager)) @@ -78,7 +77,6 @@ for doing this. The connection will last until @scheme[timer] triggers. } -@; XXX Don't pass in parent-cust @defproc[(start-connection-manager [parent-cust custodian?]) void]{ Runs the connection manager (now just the timer manager) will @scheme[parent-cust] @@ -164,8 +162,6 @@ The @scheme[dispatch-server^] signature is an alias for The @schememodname[web-server/private/dispatch-server-unit] module provides the unit that actually implements a dispatching server. -@; XXX Talk about how threads and custodians are used. - @defthing[dispatch-server@ (unit/c (tcp^ dispatch-server-config^) (dispatch-server^))]{ Runs the dispatching server config in a very basic way, except that it uses @@ -371,7 +367,6 @@ needs. They are provided by @filepath{private/util.ss}. Replaces the URL path of @scheme[u] with @scheme[proc] of the former path. } -@; XXX Remove use or take url? @defproc[(url-path->string [url-path (listof path/param?)]) string?]{ Formats @scheme[url-path] as a string with @scheme["/"] as a delimiter @@ -417,7 +412,6 @@ needs. They are provided by @filepath{private/util.ss}. according to @scheme[exn]. } -@; XXX Remove @defproc[(network-error [s symbol?] [fmt string?] [v any/c] ...) diff --git a/collects/web-server/scribblings/servlet.scrbl b/collects/web-server/scribblings/servlet.scrbl index 551c74d2d0..f51887da51 100644 --- a/collects/web-server/scribblings/servlet.scrbl +++ b/collects/web-server/scribblings/servlet.scrbl @@ -128,8 +128,6 @@ This is what @scheme[send/suspend/dispatch] gives to its function argument. @defmodule[web-server/private/request-structs] -@; XXX Create http sub-directory -@; XXX Have this include read-request and write-response @filepath{private/request-structs.ss} provides a number of structures and functions related to HTTP request data structures. @@ -271,7 +269,6 @@ Here is an example typical of what you will find in many applications: @filepath{private/response-structs.ss} provides structures and functions related to HTTP responses. -@; XXX Only use bytes @defstruct[response/basic ([code number?] [message string?] @@ -293,7 +290,6 @@ HTTP responses. ] } -@; XXX Rename string? option @defstruct[(response/full response/basic) ([body (listof (or/c string? bytes?))])]{ As with @scheme[response/basic], except with @scheme[body] as the response @@ -486,7 +482,6 @@ functions of interest for the servlet developer.} Calls @scheme[send/forward] with @scheme[redirect-to]. } -@; XXX Move @defproc[(adjust-timeout! [t number?]) void?]{ Calls the servlet's manager's @scheme[adjust-timeout!] function. @@ -494,7 +489,6 @@ functions of interest for the servlet developer.} @warning{This is deprecated and will be removed in a future release.} } -@; XXX Remove @defthing[current-url-transform (parameter/c url-transform?)]{ Holds a @scheme[url-transform?] function that is called by @scheme[send/suspend] to transform the URLs it generates. @@ -508,7 +502,6 @@ functions of interest for the servlet developer.} returns the instance id, continuation id, and nonce. } -@; XXX Remove @defproc[(embed-ids [ids (list/c number? number? number?)] [u url?]) string?]{ @@ -524,7 +517,6 @@ functions of interest for the servlet developer.} @filepath{servlet/helpers.ss} provides functions built on @filepath{servlet/web.ss} that are useful in many servlets. -@; XXX Move into http/response.ss @defproc[(redirect-to [uri string?] [perm/temp redirection-status? temporarily] [#:headers headers (listof header?) (list)]) @@ -562,7 +554,6 @@ functions of interest for the servlet developer.} ] } -@; XXX Depreciate @; ------------------------------------------------------------ @section[#:tag "servlet-url.ss"]{Servlet URLs} @(require (for-label web-server/servlet/servlet-url)) @@ -581,7 +572,6 @@ They may eventually provided by another module. that went into @scheme[su]. } -@; XXX Support Digest @; ------------------------------------------------------------ @section[#:tag "basic-auth.ss"]{Basic Authentication} @(require (for-label web-server/servlet/basic-auth))