suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Raise a better message for ctc generation in TR

Browse Source 
This provides a better explanation of contract generation
failures for module-provided bindings.
This commit is contained in:
Asumu Takikawa 2014-03-14 09:54:17 -04:00
parent 5600213a5a
commit 30b60f8c43
2 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/typecheck/provide-handling.rkt
View File

@ -4,6 +4,7 @@
unstable/list unstable/sequence syntax/id-table racket/dict racket/syntax
racket/struct-info racket/match syntax/parse
(only-in (private type-contract) type->contract)
(types printer)
(typecheck renamer def-binding)
(utils tc-utils)
(for-syntax racket/base)
@ -133,13 +134,13 @@
;; mk-value-triple : identifier? identifier? (or/c syntax? #f) -> triple/c
(define (mk-value-triple internal-id new-id ty)
(define contract (type->contract ty (λ (#:reason [reason #f]) #f)))
(define contract (type->contract ty (λ (#:reason [reason #f]) reason)))
(with-syntax* ([id internal-id]
[untyped-id (freshen-id #'id)]
[export-id new-id])
(define/with-syntax definitions
(if contract
(if (syntax? contract)
(with-syntax* ([module-source pos-blame-id]
[the-contract (generate-temporary 'generated-contract)])
#`(define-module-boundary-contract untyped-id
@ -150,8 +151,12 @@
#,(syntax-column #'id)
#,(syntax-position #'id)
#,(syntax-span #'id))))
#'(define-syntax (untyped-id stx)
(tc-error/stx stx "The type of ~a cannot be converted to a contract" (syntax-e #'id)))))
#`(define-syntax (untyped-id stx)
(tc-error/fields #:stx stx
"could not convert type to a contract"
#:more #,contract
"for identifier" #,(symbol->string (syntax-e #'id))
"type" #,(pretty-format-type ty #:indent 8)))))
(values
#'(begin
definitions

12
pkgs/typed-racket-pkgs/typed-racket-test/tests/typed-racket/fail/contract-conversion-error.rkt Normal file
View File

@ -0,0 +1,12 @@
#;
(exn-pred #rx"function type has two cases of arity 1")
#lang racket/load
;; This tests the error message for contract generation errors
;; that come from module provides.
;;
;; In particular, it should give a reason for why it failed
(module a typed/racket (define v values) (provide v))
(require 'a)
v