From 384e1392bd985c7f376f54df9a24374a40532e35 Mon Sep 17 00:00:00 2001 From: Asumu Takikawa Date: Wed, 22 May 2013 22:47:48 -0400 Subject: [PATCH] Cleanup FIXME comments --- .../typed-racket-lib/typed-racket/base-env/class-prims.rkt | 4 +--- .../typed-racket/typecheck/check-class-unit.rkt | 7 ------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/base-env/class-prims.rkt b/pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/base-env/class-prims.rkt index 38fd027f2e..4fecabc5ef 100644 --- a/pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/base-env/class-prims.rkt +++ b/pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/base-env/class-prims.rkt @@ -162,7 +162,6 @@ ;; Listof -> Hash ;; Extract names from init, public, etc. clauses - ;; FIXME: deal with internal vs. external names (define (extract-names clauses) (for/fold ([clauses (make-immutable-free-id-table)]) ([clause clauses]) @@ -283,8 +282,7 @@ #:literals (define-values super-new) ;; if it's a method definition for a declared method, then ;; mark it as something to type-check - ;; FIXME: this needs to handle external/internal names too - ;; FIXME: this needs to track privates, augments, etc. + ;; FIXME: this needs to track augments, etc. [(define-values (id) . rst) #:when (memf (λ (n) (free-identifier=? #'id n)) (append (stx-map stx-car (dict-ref name-dict #'public '())) diff --git a/pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/typecheck/check-class-unit.rkt b/pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/typecheck/check-class-unit.rkt index cc60ae9417..9e193a8750 100644 --- a/pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/typecheck/check-class-unit.rkt +++ b/pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/typecheck/check-class-unit.rkt @@ -367,11 +367,6 @@ ;; -> List List List List ;; Construct mappings to put into the lexical type-checking environment ;; from the class local accessor mappings -;; -;; FIXME: the types we put here are fine in the expected -;; case, but not if the class doesn't have an annotation. -;; Then we need to hunt down annotations in a first pass. -;; (should probably do this in expected case anyway) (define (local-tables->lexical-env internal-external-mapping local-method-table methods method-names local-field-table fields field-names @@ -763,8 +758,6 @@ (for/or ([m (in-set required)]) (and (not (set-member? actual m)) m))) (when missing - ;; FIXME: make this a delayed error? Do it for every single - ;; name separately? (tc-error/expr "class definition missing ~a ~a" msg missing))) ;; Set Set String -> Void