suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix a problem with loading and saving files, specifically those with

Browse Source 
metadata:

If there is an error opening the file to be saved for write,
`on-save-file' is called, but `after-save-file' isn't.  As
`on-save-file' creates the metadata, and `after-save-file' zaps it
again, corruption results.  To fix, open the file inside the relevant
`dynamic-wind' rather than before.

The analogous problem existed with loading.

svn: r7602
This commit is contained in:
Mike Sperber 2007-11-01 09:31:59 +00:00
parent eda498ed24
commit 3ab3a7300c
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
collects/mred/private/editor.ss
View File

@ -148,11 +148,12 @@
(begin
(or (not load?)
(on-load-file file (-format-filter format)))
(let ([port (open-input-file file)]
(let ([port #f]
[finished? #f])
(dynamic-wind
void
(lambda ()
(set! port (open-input-file file))
(wx:begin-busy-cursor)
(super-begin-edit-sequence)
(dynamic-wind
@ -188,7 +189,7 @@
#t)
(lambda ()
;; In case it wasn't closed before:
(close-input-port port)
(if port (close-input-port port))
(when load?
(after-load-file finished?))))))))))])
(public*
@ -222,18 +223,19 @@
(-get-file-format)
f-format)]
[text? (memq actual-format '(text text-force-cr))])
(let ([port (open-output-file file (if text? 'text 'binary) 'truncate/replace)]
(let ([port #f]
[finished? #f])
(dynamic-wind
void
(lambda ()
(set! port (open-output-file file (if text? 'text 'binary) 'truncate/replace))
(wx:file-creator-and-type file #"mReD" (if text? #"TEXT" #"WXME"))
(wx:begin-busy-cursor)
(dynamic-wind
void
(lambda ()
(super-save-port port format #t)
(close-output-port port) ; close as soon as possible
(close-output-port port) ; close as soon as possible
(unless (or (eq? format 'copy)
(and (not (unbox temp-filename?-box))
(equal? file old-filename)))
@ -248,7 +250,7 @@
#t)
(lambda ()
;; In case it wasn't closed before:
(close-output-port port)
(if port (close-output-port port))
(after-save-file finished?))))))))))])
(public*