From 40121d25314656930b0b4f6590835219b9672a6d Mon Sep 17 00:00:00 2001
From: Robby Findler <robby@racket-lang.org>
Date: Sun, 19 Aug 2012 17:07:19 -0500
Subject: [PATCH] improve the menu redundancy test so it reports when there are
 multiple menu items with the same shortcut

---
 .../drracket/no-write-and-frame-leak.rkt      | 27 ++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)

diff --git a/collects/tests/drracket/no-write-and-frame-leak.rkt b/collects/tests/drracket/no-write-and-frame-leak.rkt
index ce1ada43f1..ce8a622bec 100644
--- a/collects/tests/drracket/no-write-and-frame-leak.rkt
+++ b/collects/tests/drracket/no-write-and-frame-leak.rkt
@@ -11,6 +11,8 @@ This test checks:
 
   - if there are any adjacent separators in the menus
 
+  - if there are any duplicate shortcuts in the menus
+
 |#
 
 (require "private/drracket-test-util.rkt"
@@ -90,14 +92,18 @@ This test checks:
   
 (define (check-menus frame)
   
+  (define shortcuts (make-hash))
+  
   (define (process-container container)
     (define sub-items (send container get-items))
     (unless (null? sub-items)
+      (record-shortcut (car sub-items))
       (when (is-a? (car sub-items) menu-item-container<%>)
         (process-container (car sub-items)))
       (define printed? #f)
       (for ([prev-item (in-list sub-items)]
             [item (in-list (cdr sub-items))])
+        (record-shortcut item)
         (when (and (is-a? prev-item separator-menu-item%)
                    (is-a? item separator-menu-item%)
                    (not printed?))
@@ -109,6 +115,18 @@ This test checks:
         (when (is-a? item menu-item-container<%>)
           (process-container item)))))
   
+  (define (record-shortcut item)
+    (when (is-a? item selectable-menu-item<%>)
+      (when (send item get-shortcut)
+        (define k (append (sort (send item get-shortcut-prefix)
+                                string<=?
+                                #:key symbol->string)
+                          (list (send item get-shortcut))))
+        (hash-set! shortcuts 
+                   k
+                   (cons (send item get-label)
+                         (hash-ref shortcuts k '()))))))
+  
   (define (get-lab item)
     (cond
       [(is-a? item labelled-menu-item<%>)
@@ -126,6 +144,13 @@ This test checks:
         [else
          '()])))
   
-  (process-container (send frame get-menu-bar)))
+  (define (check-shortcuts)
+    (for ([(k v) (in-hash shortcuts)])
+      (unless (= 1 (length v))
+        (eprintf "found multiple menu items with the shortcut ~s: ~s\n"
+                 k v))))
+  
+  (process-container (send frame get-menu-bar))
+  (check-shortcuts))
 
 (main)