From 469bc6ec00898fec3458f755eb7f390c60651988 Mon Sep 17 00:00:00 2001
From: Robby Findler <robby@racket-lang.org>
Date: Thu, 22 Sep 2011 07:33:03 -0500
Subject: [PATCH] change the online check syntax so it doesn't require any
 preferences to be set up in the separate place

---
 collects/drracket/private/syncheck/gui.rkt         | 11 ++++++++++-
 collects/drracket/private/syncheck/online-comp.rkt |  2 --
 collects/drracket/private/syncheck/traversals.rkt  |  4 +---
 3 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/collects/drracket/private/syncheck/gui.rkt b/collects/drracket/private/syncheck/gui.rkt
index 2f49c23038..cebd0577ff 100644
--- a/collects/drracket/private/syncheck/gui.rkt
+++ b/collects/drracket/private/syncheck/gui.rkt
@@ -663,9 +663,18 @@ If the namespace does not, they are colored the unbound color.
                 (when (<= 0 start-pos end-pos (last-position))
                   (add-to-range/key text start-pos end-pos make-menu key (and key #t)))))
             
-            (define/public (syncheck:add-background-color text start fin color)
+            (define/public (syncheck:add-background-color text start fin raw-color)
               (when arrow-records
                 (when (is-a? text text:basic<%>)
+                  ;; we adjust the colors over here based on the white-on-black
+                  ;; preference so we don't have to have the preference set up
+                  ;; in the other place when running check syntax in online mode.
+                  (define color 
+                    (if (preferences:get 'framework:white-on-black?)
+                        (cond
+                          [(equal? raw-color "palegreen") "darkgreen"]
+                          [else raw-color])
+                        raw-color))
                   (add-to-range/key text start fin (make-colored-region color text start fin) #f #f))))
             
             ;; syncheck:add-arrow : symbol text number number text number number boolean -> void
diff --git a/collects/drracket/private/syncheck/online-comp.rkt b/collects/drracket/private/syncheck/online-comp.rkt
index e57a662653..7d0dc3b7b0 100644
--- a/collects/drracket/private/syncheck/online-comp.rkt
+++ b/collects/drracket/private/syncheck/online-comp.rkt
@@ -7,8 +7,6 @@
          "xref.rkt"
          framework/preferences)
 
-(preferences:set-default 'framework:white-on-black? #f boolean?)
-
 (provide go)
 
 (define obj%
diff --git a/collects/drracket/private/syncheck/traversals.rkt b/collects/drracket/private/syncheck/traversals.rkt
index 5db4df5c8d..4ac6b3ebff 100644
--- a/collects/drracket/private/syncheck/traversals.rkt
+++ b/collects/drracket/private/syncheck/traversals.rkt
@@ -1053,9 +1053,7 @@
               (define-values (entry-desc path tag) (apply values info))
               (send defs-text syncheck:add-background-color
                     source-editor start fin 
-                    (if (preferences:get 'framework:white-on-black?)
-                        "darkgreen"
-                        "palegreen"))
+                    "palegreen")
               (send defs-text syncheck:add-docs-menu
                     source-editor
                     start