Disallow non-productive PolyRow types

Closes PR 14554

pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/env/type-alias-helper.rkt

@@ -68,6 +68,7 @@
     [((Mu: _ body)) (check body)]
     [((Poly: names body)) (check body)]
     [((PolyDots: names body)) (check body)]
+    [((PolyRow: _ _ body)) (check body)]
     [(_) #t])
   (unless (check type)
     (tc-error/stx

pkgs/typed-racket-pkgs/typed-racket-lib/typed-racket/private/parse-type.rkt

@@ -376,6 +376,7 @@
                   [(Mu: _ body) (loop body)]
                   [(Poly: names body) (loop body)]
                   [(PolyDots: names body) (loop body)]
+                  [(PolyRow: _ _ body) (loop body)]
                   [else #t])))
              (unless productive
                (parse-error

pkgs/typed-racket-pkgs/typed-racket-test/tests/typed-racket/unit-tests/parse-type-tests.rkt

@@ -117,6 +117,10 @@
     (-polydots (a) ((list) [a a] . ->... . N))]
    [(All (a ...) (-> (values a ...)))
     (-polydots (a) (t:-> (make-ValuesDots (list) a 'a)))]
+
+   ;; PR 14554, non-productive recursive type
+   [FAIL (Rec x (All (A #:row) x))]
+
    [(case-lambda (Number -> Boolean) (Number Number -> Number)) (cl-> [(N) B]
                                                                       [(N N) N])]
    [(case-> (Number -> Boolean) (Number Number -> Number)) (cl-> [(N) B]

pkgs/typed-racket-pkgs/typed-racket-test/tests/typed-racket/unit-tests/typecheck-tests.rkt

@@ -2616,6 +2616,8 @@
                #:msg "Recursive #:implements clause not allowed"]
        [tc-err (let () (define-type-alias X (U X #f)) "dummy")
                #:msg "Recursive types are not allowed directly inside"]
+       [tc-err (let () (define-type-alias X (All (A #:row) X)) "dummy")
+               #:msg "Recursive types are not allowed directly inside"]
 
        ;; Check the more precise Tarjan's algorithm-based letrec-values type checking
        [tc-e ;; An example from Eric Dobson (see gh372) that shows that precisely