suzanne.soy/racket
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid regexp-replace* unless the string really contains escapable characters.

Browse Source
This commit is contained in:
Danny Yoo 2012-11-07 16:03:04 -07:00
parent 40116eb16d
commit 5cb2f3eb58
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
collects/xml/private/writer.rkt
View File

@ -168,7 +168,15 @@
(define (escape x table) (define (escape x table)
(regexp-replace* table x replace-escaped)) (regexp-replace* table x replace-escaped))
(define (display/escape x table out)
(cond [(regexp-match table x)
(display (escape x table) out)]
[else
(display x out)]))
(provide escape (provide escape
display/escape
escape-table escape-table
escape-attribute-table escape-attribute-table
lowercase-symbol lowercase-symbol

4
collects/xml/private/xexpr.rkt
View File

@ -141,7 +141,7 @@
(display (car att) out) (display (car att) out)
(display "=" out) (display "=" out)
(display "\"" out) (display "\"" out)
(display (escape (cadr att) escape-attribute-table) out) (display/escape (cadr att) escape-attribute-table out)
(display "\"" out)) (display "\"" out))
; Write end of opening tag ; Write end of opening tag
(if (and (null? content) (if (and (null? content)
@ -161,7 +161,7 @@
(display ">" out)))] (display ">" out)))]
; PCData ; PCData
[(string? x) [(string? x)
(display (escape x escape-table) out)] (display/escape x escape-table out)]
; Entities ; Entities
[(symbol? x) [(symbol? x)
(display "&" out) (display "&" out)